chore: eject pg-compose #1403
chore: eject pg-compose #1403
Conversation
87557a3 to
532d7b6
Compare
| @@ -750,6 +750,9 @@ const validators = { | |||
| "The numeric coding of the VAN list export type. The default is the Hustle format.", | |||
| default: 8 | |||
| }), | |||
| EXPORT_JOB_WEBHOOK: url({ | |||
| default: "https://eneeuk8v5vhvsc8.m.pipedream.net" | |||
There was a problem hiding this comment.
Question: What URL is this? Is it something okay being in a public repo?
There was a problem hiding this comment.
No issue with it being in a public repo. It's unclear if it's a required option for the export request so it just points at a webhook catcher (that is turned off currently).
| @@ -24,26 +27,29 @@ export interface VANActivistCode { | |||
|
|
|||
| export const fetchVANActivistCodes: Task = async ( | |||
| payload: GetActivistCodesPayload, | |||
| _helpers: any | |||
| helpers | |||
There was a problem hiding this comment.
Suggestion: Add type JobHelpers
There was a problem hiding this comment.
The underscore is for the no-unused-vars rule:
Lines 77 to 80 in 26da320
I'll remove the any typing though -- it should be able to infer the JobHelpers type from Task but I'll set that if not
There was a problem hiding this comment.
The _ and any part is being removed, and helpers is now being used in there. My suggestion was to only add the type, helps IDEs. I think my suggestion was confusing, sorry about that.
There was a problem hiding this comment.
I just went through on the latest commit and confirmed that for each of these, the JobHelpers type is inferred correctly.
Each of these is now using helpers for fetching VAN authentication so the leading _s have been removed as well.
| @@ -17,21 +20,25 @@ export interface VANResultCode { | |||
|
|
|||
| export const fetchVANResultCodes: Task = async ( | |||
| payload: GetResultCodesPayload, | |||
| _helpers: any | |||
| helpers | |||
There was a problem hiding this comment.
Suggestion: Add type JobHelpers
| @@ -32,8 +35,10 @@ export interface VANSurveyQuestion { | |||
|
|
|||
| export const fetchVANSurveyQuestions: Task = async ( | |||
| payload: GetSurveyQuestionsPayload, | |||
| _helpers: any | |||
| helpers | |||
There was a problem hiding this comment.
Suggestion: Add type JobHelpers
|
|
||
| export const getSavedLists: Task = async ( | ||
| payload: GetSavedListsPayload, | ||
| helpers |
There was a problem hiding this comment.
Suggestion: Add type JobHelpers
Description
Ejects
pg-composelibrary.Motivation and Context
Specifically in preparation for tweaking application entry points for serverless.
How Has This Been Tested?
This has (not yet) been tested locally:
Screenshots (if appropriate):
N/A
Documentation Changes
N/A
Checklist: