Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(people): fix searching by only campaign #1368

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Conversation

bchrobot
Copy link
Member

Description

This PR does two things:

  1. Fixes a BAD_USER_INPUT Apollo error
  2. Fixes the join on assignment to work when searching only on campaign, and not user

Motivation and Context

Searching by campaign expected the user table to have already been joined but that was not necessarily the case.

How Has This Been Tested?

This has been tested locally.

Screenshots (if appropriate):

N/A

Documentation Changes

N/A

Checklist:

  • My change requires a change to the documentation.
  • I have included updates for the documentation accordingly.

@bchrobot bchrobot added problem: bug 🦠 Something isn't working platform: node 🔅 Related to Node backend labels Aug 28, 2022
@bchrobot bchrobot added this to the 4.37.0 milestone Aug 28, 2022
@bchrobot bchrobot requested review from hiemanshu and ajohn25 August 28, 2022 10:51
@bchrobot bchrobot changed the title fix(people): add missing join on user table fix(people): fix searching by only campaign Aug 28, 2022
@bchrobot bchrobot merged commit 29e9d88 into main Sep 1, 2022
@bchrobot bchrobot deleted the fix-members-query branch September 1, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: node 🔅 Related to Node backend problem: bug 🦠 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants