Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust): add str_slice method to StringNameSpace #8427

Merged
merged 2 commits into from
Apr 22, 2023
Merged

feat(rust): add str_slice method to StringNameSpace #8427

merged 2 commits into from
Apr 22, 2023

Conversation

ayemjay
Copy link
Contributor

@ayemjay ayemjay commented Apr 22, 2023

Fixes #8426

Continued with str_slice convention as not confuse with array slice.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature rust Related to Rust Polars labels Apr 22, 2023
@ritchie46
Copy link
Member

Thanks! While you are at it, can you immediately dispatch the python str.str_slice via this method as well?

@ayemjay
Copy link
Contributor Author

ayemjay commented Apr 22, 2023

Would you prefer a separate PR for this?

@ritchie46
Copy link
Member

Thanks, looks great!

@ritchie46 ritchie46 merged commit 71dd8f1 into pola-rs:main Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add str_slice method to StringNameSpace
2 participants
@ayemjay @ritchie46