Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): Use check_exact for temporal types in assert_series_equal #7896

Merged
merged 3 commits into from
Mar 31, 2023
Merged

fix(python): Use check_exact for temporal types in assert_series_equal #7896

merged 3 commits into from
Mar 31, 2023

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented Mar 31, 2023 •
edited
Loading

Closes #7892

Not sure this is the most satisfying solution, but it works for now.

Ideally, we'd also be able to check temporal types with a tolerance.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Mar 31, 2023
@ritchie46 ritchie46 merged commit 2e64987 into pola-rs:master Mar 31, 2023
@stinodego stinodego deleted the fix-assert-frame-datetime branch May 25, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assert_frame_equal doesn't work correctly for Datetime types
2 participants
@stinodego @ritchie46