-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): add include_index
option on init from pandas frames
#6847
feat(python): add include_index
option on init from pandas frames
#6847
Conversation
Nice! Shall we immediately make it keyword only? |
Sure, let's do it; it is this season's on-trend coding style... :) |
0d4e0f6
to
25055ec
Compare
25055ec
to
d6d7142
Compare
@ritchie46: done - |
Thanks everybody! For the good reviews and solutions! |
Closes #6763.
Allows for optional loading of non-default pandas frame indexes as columns; defaults to False to ensure no changes in behaviour - we can revisit that default later, if requested/desired.
Setup
Before (caller has to manually reset the index if they want to load it)
After (new param allows for easy/optimised index load)
Update
Using this method is now optimal in comparison to the caller using
reset_index
, as we're able to avoid the pandas-side copy that would trigger.