Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): Consider the original dtypes when selecting columns in write_excel function #20909

Merged
merged 8 commits into from
Jan 25, 2025
Merged

fix(python): Consider the original dtypes when selecting columns in write_excel function #20909

merged 8 commits into from
Jan 25, 2025
+58 −2

Conversation

arnabanimesh
Copy link
Contributor

@arnabanimesh arnabanimesh commented Jan 25, 2025 •
edited
Loading

No description provided.

@arnabanimesh arnabanimesh changed the title fix(python): Consider the original dtypes when selecting columns in t… fix(python): Consider the original dtypes when selecting columns in write_excel function Jan 25, 2025
@github-actions github-actions bot added fix Bug fix python Related to Python Polars and removed title needs formatting labels Jan 25, 2025
@arnabanimesh
Copy link
Contributor Author

Fixes #20910

@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.77%. Comparing base (7bf42dd) to head (f4ff181).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #20909   +/-   ##
=======================================
  Coverage   79.76%   79.77%           
=======================================
  Files        1569     1569           
  Lines      222895   222898    +3     
  Branches     2573     2574    +1     
=======================================
+ Hits       177782   177806   +24     
+ Misses      44521    44500   -21     
  Partials      592      592

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alexander-beedie
alexander-beedie requested changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs unit test coverage before it can be approved (and a small varname change), but otherwise looks good, thanks 👍

py-polars/polars/dataframe/frame.py Outdated Show resolved Hide resolved
@arnabanimesh
Copy link
Contributor Author

@alexander-beedie changed the variable name and added unit tests. It is ready to review.

@alexander-beedie alexander-beedie merged commit 6d7eade into pola-rs:main Jan 25, 2025
15 checks passed
@alexander-beedie alexander-beedie mentioned this pull request Jan 25, 2025
Closed
2 tasks
@arnabanimesh arnabanimesh deleted the patch-3 branch January 25, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-beedie alexander-beedie alexander-beedie approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnabanimesh @alexander-beedie