Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Properly raise UDF errors #20417

Merged
merged 9 commits into from
Dec 23, 2024
Merged

fix(python): Properly raise UDF errors #20417

merged 9 commits into from
Dec 23, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Dec 23, 2024

Always raise the errors instead of silently ignoring them. Also removes a panics.

fixes #19315
fixes #17499
fixes #11823
fixes #12675

And I assume a few other panic related issues.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 37.94872% with 363 lines in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (f242871) to head (5d10c6f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/map/series.rs 33.12% 315 Missing ⚠️
crates/polars-python/src/map/dataframe.rs 24.13% 22 Missing ⚠️
crates/polars-python/src/map/mod.rs 76.92% 15 Missing ⚠️
crates/polars-python/src/dataframe/general.rs 0.00% 10 Missing ⚠️
crates/polars-python/src/series/map.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20417   +/-   ##
=======================================
  Coverage   78.98%   78.98%           
=======================================
  Files        1562     1562           
  Lines      220111   220159   +48     
  Branches     2486     2486           
=======================================
+ Hits       173855   173897   +42     
- Misses      45683    45689    +6     
  Partials      573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 8df0cbe into main Dec 23, 2024
29 checks passed
@ritchie46 ritchie46 deleted the error branch December 23, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
1 participant