Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused IPC async #19223

Merged
merged 2 commits into from
Oct 14, 2024
Merged

chore: Remove unused IPC async #19223

merged 2 commits into from
Oct 14, 2024

Conversation

ritchie46
Copy link
Member

Remove unused async IPC code. Was not useful to us as it was overly generic, where we use the tokio runtime and need an adaptor to convert to futures::AsyncRead.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.96%. Comparing base (e29e9df) to head (ce2f1fa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19223      +/-   ##
==========================================
+ Coverage   79.68%   79.96%   +0.28%     
==========================================
  Files        1532     1526       -6     
  Lines      209211   208489     -722     
  Branches     2416     2416              
==========================================
+ Hits       166710   166719       +9     
+ Misses      41953    41222     -731     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 44cf3ad into main Oct 14, 2024
19 checks passed
@ritchie46 ritchie46 deleted the ipc branch October 14, 2024 08:00
@c-peters c-peters added the accepted Ready for implementation label Oct 14, 2024
@PrettyWood
Copy link

@ritchie46 Following @lukapeschke 's comment here we rely on this code and it prevents us from upgrading polars. Would you mind considering a PR to reimplement part of the logic, maybe simplified considering your comment?
We are ok to contribute and write the code but need your guidelines for the expected API 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants