Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Don't trigger row limit in array construction #19215

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

ritchie46
Copy link
Member

fixes #19203

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (207ddb0) to head (cb2fb7a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/_utils/construction/series.py 27.27% 14 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19215      +/-   ##
==========================================
- Coverage   79.67%   79.67%   -0.01%     
==========================================
  Files        1532     1532              
  Lines      209190   209198       +8     
  Branches     2415     2417       +2     
==========================================
+ Hits       166677   166679       +2     
- Misses      41967    41971       +4     
- Partials      546      548       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit cca31b3 into main Oct 13, 2024
27 checks passed
@ritchie46 ritchie46 deleted the limit branch October 13, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stated Limit is for 4.3 Billion rows, but really its 4.3 billion elements before needing polars-u64-idx
1 participant