-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Use two-pass algorithm for csv to ensure correctness and SIMDize more ~17%
#19088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
Bug fix
python
Related to Python Polars
rust
Related to Rust Polars
labels
Oct 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19088 +/- ##
=======================================
Coverage 79.78% 79.78%
=======================================
Files 1531 1531
Lines 208568 208561 -7
Branches 2913 2913
=======================================
+ Hits 166405 166409 +4
+ Misses 41612 41601 -11
Partials 551 551 ☔ View full report in Codecov by Sentry. |
ritchie46
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
October 4, 2024 15:37
ritchie46
changed the title
fix: Use two-pass algorithm for csv to ensure correctness
perf: Use two-pass algorithm for csv to ensure correctness and SIMDize more
Oct 5, 2024
ritchie46
changed the title
perf: Use two-pass algorithm for csv to ensure correctness and SIMDize more
perf: Use two-pass algorithm for csv to ensure correctness and SIMDize more Oct 5, 2024
~17%
i find v1.10 is slower (2.6s vs 1.7s) than v1.7.1 for my 6gb quoted file for doing sum of a column |
This was referenced Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fix
Bug fix
performance
Performance issues or improvements
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19078
Fixed so that we always have chunks that are valid. As we now have a two pass algorithm, made sure to SIMDize more. What is lost by the two pass, is gained by SIMD. On NY city trip data I have ~17% perf improvement.
The good thing is that we are now always fast, as we don't have to fallback to single threaded code anymore when we encounter a complicated/quoted file.