Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raise invalid predicate join_where #19020

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: Raise invalid predicate join_where #19020

merged 1 commit into from
Sep 30, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Sep 30, 2024

fixes #18745

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 30, 2024
@ritchie46 ritchie46 merged commit f958881 into main Sep 30, 2024
25 checks passed
@ritchie46 ritchie46 deleted the join branch September 30, 2024 12:11
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.87%. Comparing base (ab5200d) to head (4ebc8a4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ates/polars-plan/src/plans/conversion/dsl_to_ir.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19020      +/-   ##
==========================================
+ Coverage   79.85%   79.87%   +0.01%     
==========================================
  Files        1524     1524              
  Lines      207734   207749      +15     
  Branches     2908     2908              
==========================================
+ Hits       165891   165939      +48     
+ Misses      41294    41261      -33     
  Partials      549      549              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

join_where ColumnNotFoundError if predicate only uses columns from one side
1 participant