fix(python): Fix list to numpy conversion #19009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
commented
Sep 29, 2024
|
|
||
| // Split the NumPy array into subarrays by offset. |
There was a problem hiding this comment.
This is wrong for 2 reasons. The slicing was incorrect, but it also doesn't include null values and can show masked out values.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19009 +/- ##
==========================================
- Coverage 79.88% 79.86% -0.03%
==========================================
Files 1524 1524
Lines 207641 207644 +3
Branches 2904 2904
==========================================
- Hits 165883 165828 -55
- Misses 41211 41269 +58
Partials 547 547 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18986