feat: Support pl.all().filter(..)
#18993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
commented
Sep 28, 2024
| ) | ||
|
|
||
| q = df.lazy().select(pl.all().filter(~pl.col("p"))) | ||
| assert "__POLARS_CSER" in q.explain() |
There was a problem hiding this comment.
CSE is important for this PR so that we don't evaluate the predicate more than once
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18993 +/- ##
==========================================
- Coverage 79.88% 79.87% -0.01%
==========================================
Files 1524 1524
Lines 207634 207631 -3
Branches 2904 2904
==========================================
- Hits 165873 165850 -23
- Misses 41214 41234 +20
Partials 547 547 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Sep 28, 2024
| @@ -1150,9 +1150,6 @@ impl Expr { | |||
| /// Should be used in aggregation context. If you want to filter on a | |||
| /// DataFrame level, use `LazyFrame::filter`. | |||
| pub fn filter<E: Into<Expr>>(self, predicate: E) -> Self { | |||
There was a problem hiding this comment.
We should check this in dsl conversion and either raise an error or translate to a Filter node.
e3635c8 to
0703188
Compare
ritchie46
reviewed
Sep 30, 2024
| input, | ||
| options, | ||
| } if { | ||
| // This is a hack so that we don't break `list.eval(pl.element().filter())`. That expression |
There was a problem hiding this comment.
Auch, we really need to replace that element => col("") hack. With a proper Expr::Element type and something that can run it.
But probably not this PR.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18733
This removes the restriction, but we could also raise a
PolarsErrorinstead if we want