Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Clarify to_torch "features" and "label" parameter behaviour when return type is not "dataset" #16218

Merged
merged 1 commit into from
May 14, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented May 14, 2024

  • Setting "label" or "features" parameters when return_type is not "dataset" now raises an informative error (previously was a silent no-op).
  • Added docstring note that selectors1 are supported for "label" and "features".

Footnotes

  1. Polars selectors: https://docs.pola.rs/py-polars/html/reference/selectors.html

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.94%. Comparing base (993cc99) to head (86f2552).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16218      +/-   ##
==========================================
- Coverage   80.99%   80.94%   -0.05%     
==========================================
  Files        1393     1393              
  Lines      179445   179562     +117     
  Branches     2907     2908       +1     
==========================================
+ Hits       145335   145342       +7     
- Misses      33604    33714     +110     
  Partials      506      506              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 3b21311 into pola-rs:main May 14, 2024
16 checks passed
@alexander-beedie alexander-beedie deleted the refine-to-torch-params branch May 14, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants