Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(rust): Update features for latest flate2 release #10492

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

ritchie46
Copy link
Member

fix for latest flate2 release

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 15, 2023
@stinodego
Copy link
Contributor

I'm merging this because I want the lockfile in the main branch 😬

@stinodego stinodego merged commit 5a87e20 into main Aug 15, 2023
@stinodego stinodego deleted the features branch August 15, 2023 08:58
@stinodego stinodego changed the title chore(rust): features build(rust): Update features for latest flate2 release Aug 15, 2023
@github-actions github-actions bot added the build Changes that affect the build system or external dependencies label Aug 15, 2023
@lorepozo
Copy link
Contributor

It looks like this change makes decompress-fast redundant — it's the same as decompress. There are these lines further down polars-io/Cargo.toml:

decompress = ["flate2/miniz_oxide"]
decompress-fast = ["flate2/zlib-ng"]

But with this change, the zlib-ng feature is always present for flate2's dependency, and zlib-ng "wins" over miniz_oxide when both are set. See the "wins" behavior here: https://github.com/rust-lang/flate2-rs/blob/main/src/ffi/mod.rs#L37

And these two features are always checked together, like so:

#[cfg(any(feature = "decompress", feature = "decompress-fast"))]
pub(crate) fn decompress(...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants