Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies #73

Merged
merged 21 commits into from
Jun 16, 2023
Merged

Updating dependencies #73

merged 21 commits into from
Jun 16, 2023

Conversation

Bidek56
Copy link
Collaborator

@Bidek56 Bidek56 commented Jun 4, 2023

Updating dependencies for:

  • rs-0.28
  • napi 2.13.1
  • Typescript 5.1.3
  • Jest 29.5

@universalmind303
Copy link
Collaborator

@Bidek56 sorry i've been slow to finish reviewing this, hoping to get to it in the next few days.

Copy link
Collaborator

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks pretty good, Just a few small comments. Thanks @Bidek56

Removing unsed and commented code
@universalmind303
Copy link
Collaborator

Thanks again @Bidek56

@universalmind303 universalmind303 merged commit 703f574 into pola-rs:main Jun 16, 2023
@Bidek56
Copy link
Collaborator Author

Bidek56 commented Jun 16, 2023

I am currently working on a new PR to update this repo to use rs-0.30.0.

@Bidek56 Bidek56 deleted the updating-deps branch June 16, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants