Fix docs for mutating shared state. #3580
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Feb 1, 2025
| @@ -33,6 +33,7 @@ system, such as SQLite. | |||
| * [Observing changes to shared state](#Observing-changes-to-shared-state) | |||
| * [Initialization rules](#Initialization-rules) | |||
| * [Deriving shared state](#Deriving-shared-state) | |||
| * [Concurrent mutations to shared state](#Concurrent-mutations-to-shared-state) | |||
There was a problem hiding this comment.
I'm moving this up higher because it's important to know this before the testing material.
mbrandonw
commented
Feb 1, 2025
Comment on lines
+457
to
+458
| same piece of shared state from multiple threads, and hence race conditions are possible. See | ||
| [Mutating Shared State][mutating-shared-state-article] for a more in-depth explanation. |
There was a problem hiding this comment.
And I'm linking out to the dedicated "Mutating Shared State" article over in the Sharing repo.
mbrandonw
commented
Feb 1, 2025
Comment on lines
-1051
to
-1053
| #### Previews | ||
|
|
||
| When a preview is run in an app target, the entry point is also created. This means if your entry |
There was a problem hiding this comment.
I believe this now can go away since we have a workaround in Dependencies...
stephencelis
reviewed
Feb 2, 2025
Sources/ComposableArchitecture/Documentation.docc/Articles/SharingState.md
Outdated
Show resolved
Hide resolved
stephencelis
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.