add parsed PDF content to expand_text_attachments #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if allow_attachments=True, and expand_text_attachments=True, text, html, and pdf files contents will automatically be added to the conversation by inserting ProtocolMessages with their contents. if enable_image_comprehension=True, image descriptions will also be added to the conversation. Also, add unit test
src/fastapi_poe/base.py
Outdated
| @@ -583,7 +583,10 @@ def insert_attachment_messages(self, query_request: QueryRequest) -> QueryReques | |||
| text_attachment_messages.append( | |||
| ProtocolMessage(role="user", content=url_attachment_content) | |||
| ) | |||
| elif "text" in attachment.content_type: | |||
| elif ( | |||
| "text" in attachment.content_type | |||
There was a problem hiding this comment.
Shouldn't this be attachment.content_type.startswith("text/")? I realize it's not new to this PR.
There was a problem hiding this comment.
Helloo Jelle. Yes I think so
respond to PR
agamble-quora
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
allow_attachments=True, andexpand_text_attachments=True,pdf files contents will automatically be added to the conversation by insertingProtocolMessageswith their contents. This already happens for text and html files, as well as image files (ifenable_image_comprehension=True).Also, add unit test