Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download_filename for specifying a filename when downloading from url #130

Merged

Conversation

agamble-quora
Copy link
Contributor

Previously the filename from the download_url was always used. This enables bots to set a custom filename for attachments they post via download_url.

Updates version to 0.0.50

@agamble-quora
Copy link
Contributor Author

This requires an internal server change which is in progress.

Copy link
Contributor

@krisyang1125 krisyang1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@agamble-quora agamble-quora force-pushed the feature/download_filename branch from cd99aac to e140816 Compare December 16, 2024 16:29
Copy link
Contributor Author

@agamble-quora agamble-quora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased this change on the latest changes and it omitted the version update. I need to fix the PR.

… url

Previously the filename from the download_url was always used. This
enables bots to set a custom filename for attachments they post via
download_url.

Updates version to 0.0.51
@agamble-quora agamble-quora force-pushed the feature/download_filename branch from d65ac7d to d23bfc2 Compare December 16, 2024 17:50
@agamble-quora agamble-quora merged commit 1eb5e67 into poe-platform:main Dec 16, 2024
20 checks passed
JohntheLi pushed a commit to JohntheLi/fastapi_poe that referenced this pull request Jan 6, 2025
… url (poe-platform#130)

Previously the filename from the download_url was always used. This
enables bots to set a custom filename for attachments they post via
download_url.

Updates version to 0.0.51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants