Remove deprecated return values from the podlet .js() and .css() methods #23
Labels
@podium/podlet
Issue is related to code in @podium/podlet
Milestone
Comments
trygve-lie
pushed a commit
to podium-lib/layout
that referenced
this issue
Jul 21, 2020
BREAKING CHANGE: In version 4 of podium it became possible to set multiple assets to a layout through its `.js()` and `.css()` methods. This did make it impossible to let these methods return a reasonable value, but to keep a backwards compatibility with version 3 of Podium, the first item passed in was returned for compatibility. This removes this compatibility with version 3 of Podium. This resolves podium-lib/issues#23
github-actions bot
pushed a commit
to podium-lib/layout
that referenced
this issue
Jul 21, 2020
# [5.0.0-next.2](v5.0.0-next.1...v5.0.0-next.2) (2020-07-21) ### Features * Remove deprecated return value on .js and .css methods ([e9052ed](e9052ed)) ### BREAKING CHANGES * In version 4 of podium it became possible to set multiple assets to a layout through its `.js()` and `.css()` methods. This did make it impossible to let these methods return a reasonable value, but to keep a backwards compatibility with version 3 of Podium, the first item passed in was returned for compatibility. This removes this compatibility with version 3 of Podium. This resolves podium-lib/issues#23
github-actions bot
pushed a commit
to podium-lib/layout
that referenced
this issue
Nov 29, 2023
# [5.0.0](v4.6.125...v5.0.0) (2023-11-29) ### Bug Fixes * Remove lodash.merge ([#157](#157)) ([ea2bc77](ea2bc77)) * Resolve merge conflicts ([be49970](be49970)) * Use latest client and proxy ([#399](#399)) ([4035461](4035461)) ### Features * Convert to ESM ([#286](#286)) ([7824568](7824568)) * Drop node 10.x support ([7e0bb22](7e0bb22)) * Remove deprecated return value on .js and .css methods ([e9052ed](e9052ed)) ### BREAKING CHANGES * Convert from CommonJS module to ESM * fix: Set type to be module Co-authored-by: Trygve Lie <trygve.lie@finn.no> * In version 4 of podium it became possible to set multiple assets to a layout through its `.js()` and `.css()` methods. This did make it impossible to let these methods return a reasonable value, but to keep a backwards compatibility with version 3 of Podium, the first item passed in was returned for compatibility. This removes this compatibility with version 3 of Podium. This resolves podium-lib/issues#23 * Only support node 12 and 14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
.js()and.css()methods in the @podium/podlet module returns a value. These are deprecated (podium-lib/podlet#57).Make it so that these does not return a value.
The text was updated successfully, but these errors were encountered: