Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make response toJSON return type serializable #378

Merged
merged 1 commit into from
May 15, 2024
Merged

fix: make response toJSON return type serializable #378

merged 1 commit into from
May 15, 2024

Conversation

wkillerud
Copy link
Contributor

Avoid returning class type, instead returning the toJSON of css and js assets.

@wkillerud
fix: make response toJSON return type serializable
026a723 
Avoid returning class type, instead returning the toJSON of
css and js assets.
trygve-lie
trygve-lie approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@trygve-lie trygve-lie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@wkillerud wkillerud merged commit dc617c1 into master May 15, 2024
7 checks passed
@wkillerud wkillerud deleted the fix/serializable-types branch May 15, 2024 13:35
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.0.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trygve-lie trygve-lie trygve-lie approved these changes

@leftieFriele leftieFriele leftieFriele approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkillerud @trygve-lie @leftieFriele