-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 194 #195
Merged
Merged
Feature/issue 194 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nlenssen2013, this looks good. I just made a few tweaks for readability & typing. The code's logic here is getting quite dense, so i'm just hoping to keep it as readable and manageable as possible. |
danielfromearth
approved these changes
Sep 12, 2023
jamesfwood
approved these changes
Sep 12, 2023
Merge branch 'bugfix/hdf5_open_file' into feature/issue-194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #194
Description
Variables requested in coordinate variables, that aren't a dimension to another variable are not included in output
Overview of work done
Change the variable subsetting in bbox to loop through all variables rather than just data variables
Overview of verification done
Test that the variable 'PRODUCT/corner' in S5P CH4 subset is returned when it is requested
Overview of integration done
Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request