Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 194 #195

Merged
merged 17 commits into from
Sep 12, 2023
Merged

Feature/issue 194 #195

merged 17 commits into from
Sep 12, 2023

Conversation

nlenssen2013
Copy link
Contributor

@nlenssen2013 nlenssen2013 commented Sep 11, 2023

Github Issue: #194

Description

Variables requested in coordinate variables, that aren't a dimension to another variable are not included in output

Overview of work done

Change the variable subsetting in bbox to loop through all variables rather than just data variables

Overview of verification done

Test that the variable 'PRODUCT/corner' in S5P CH4 subset is returned when it is requested

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

  • [ x] Linted
  • [ x] Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@nlenssen2013 nlenssen2013 marked this pull request as ready for review September 12, 2023 13:15
@danielfromearth
Copy link
Collaborator

@nlenssen2013, this looks good. I just made a few tweaks for readability & typing. The code's logic here is getting quite dense, so i'm just hoping to keep it as readable and manageable as possible.

@nlenssen2013 nlenssen2013 merged commit 0993668 into develop Sep 12, 2023
@nlenssen2013 nlenssen2013 deleted the feature/issue-194 branch September 12, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants