Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1.5.0]
Fixed
Github Issue: #243
Description
Fix bug where not all feature_id time steps (records) were returned in a query. The results returned from the DynamoDB table were not being paginated and only returning the first x number of records for the time range queried.
Overview of work done
get_series_by_feature_id
.LastEvaluatedKey
.Overview of verification done
Overview of integration done
Deployed feature branch to SIT and ran tests on reaches, nodes, and prior lakes.
PAGINATION OPERATIONS TEST
NORMAL OPERATIONS CONFIRMED
Reaches
curl --location --request GET 'https://soto.podaac.uat.earthdatacloud.nasa.gov/hydrocron/v1/timeseries?feature=Reach&feature_id=63470800171&start_time=2022-12-01T00:00:00%2b00:00&end_time=2024-10-30T00:00:00%2b00:00&output=csv&fields=reach_id,time_str,wse,width'
Nodes
curl --location --request GET 'https://soto.podaac.uat.earthdatacloud.nasa.gov/hydrocron/v1/timeseries?feature=Node&feature_id=28311800020621&start_time=2022-12-01T00:00:00%2b00:00&end_time=2024-10-30T00:00:00%2b00:00&output=csv&fields=node_id,time_str,wse,width'
Prior Lakes
curl --location --request GET 'https://soto.podaac.uat.earthdatacloud.nasa.gov/hydrocron/v1/timeseries?feature=PriorLake&feature_id=8130049982&start_time=2022-12-01T00:00:00%2b00:00&end_time=2024-10-30T00:00:00%2b00:00&output=csv&fields=lake_id,time_str,wse,ds1_l,p_storage'
BENCHMARK TESTS RUN
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request