Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.5.0 #244

Merged
merged 7 commits into from
Oct 10, 2024
Merged

Release/1.5.0 #244

merged 7 commits into from
Oct 10, 2024

Conversation

nikki-t
Copy link
Collaborator

@nikki-t nikki-t commented Oct 9, 2024

[1.5.0]

Fixed

- Issue 243 - Fix cases where not all time steps were returned for a feature id

Github Issue: #243

Description

Fix bug where not all feature_id time steps (records) were returned in a query. The results returned from the DynamoDB table were not being paginated and only returning the first x number of records for the time range queried.

Overview of work done

  • Combined Hydrocron SWOT table API queries into a single method: get_series_by_feature_id.
  • Modified method to paginate results using the LastEvaluatedKey.

Overview of verification done

  • Existing functionality maintained and testing pagination requires many records bumping up agains the expectation of the time it takes to run a unit test, so no new unit tests were created.
  • Testing was completed locally to determine that pagination executed successfully.
  • Existing unit tests pass.

Overview of integration done

Deployed feature branch to SIT and ran tests on reaches, nodes, and prior lakes.

PAGINATION OPERATIONS TEST

  • Confirmed that pagination issue for reach # 81220100891 returned 59 number of results prior to fix deployment (total of 112 stored in Hydrocron SWOT table).
  • After fix deployment Hydrocron table query returned 112 number of results which is the total number present in the Hydrocron SWOT table.
https://soto.podaac.uat.earthdatacloud.nasa.gov/hydrocron/v1/timeseries?feature=Reach&feature_id=81220100891&start_time=2023-07-01T00:00:00Z&end_time=2024-10-04T00:00:00Z&fields=reach_id,time_str,wse,granuleUR&output=geojson&compact=true

NORMAL OPERATIONS CONFIRMED

Reaches

curl --location --request GET 'https://soto.podaac.uat.earthdatacloud.nasa.gov/hydrocron/v1/timeseries?feature=Reach&feature_id=63470800171&start_time=2022-12-01T00:00:00%2b00:00&end_time=2024-10-30T00:00:00%2b00:00&output=csv&fields=reach_id,time_str,wse,width'
{"status":"200 OK","time":902.5,"hits":6,"results":{"csv":"reach_id,time_str,wse,width,wse_units,width_units\n63470800171,2024-02-01T02:26:50Z,483.8476,54.741816,m,m\n63470800171,2024-02-08T13:48:41Z,484.4712,167.205488,m,m\n63470800171,2024-02-21T23:11:55Z,483.8389,55.561678,m,m\n63470800171,2024-02-29T10:33:46Z,483.4376,142.581892,m,m\n63470800171,2024-05-02T00:48:58Z,483.6771,105.203136,m,m\n63470800171,2024-05-15T10:12:13Z,484.228,52.056075,m,m\n","geojson":{}}}

Nodes

curl --location --request GET 'https://soto.podaac.uat.earthdatacloud.nasa.gov/hydrocron/v1/timeseries?feature=Node&feature_id=28311800020621&start_time=2022-12-01T00:00:00%2b00:00&end_time=2024-10-30T00:00:00%2b00:00&output=csv&fields=node_id,time_str,wse,width'
{"status":"200 OK","time":461.362,"hits":7,"results":{"csv":"node_id,time_str,wse,width,wse_units,width_units\n28311800020621,2024-01-28T08:15:21Z,-15.54433,197.950116,m,m\n28311800020621,2024-01-31T21:37:09Z,-15.63838,141.288713,m,m\n28311800020621,2024-02-07T06:37:36Z,-999999999999.0,139.510183,m,m\n28311800020621,2024-02-10T19:59:24Z,-14.46997,142.574536,m,m\n28311800020621,2024-02-18T05:00:26Z,-15.99808,203.328918,m,m\n28311800020621,2024-02-21T18:22:14Z,-999999999999.0,147.694447,m,m\n28311800020621,2024-02-28T03:22:42Z,-999999999999.0,152.345847,m,m\n","geojson":{}}}

Prior Lakes

curl --location --request GET 'https://soto.podaac.uat.earthdatacloud.nasa.gov/hydrocron/v1/timeseries?feature=PriorLake&feature_id=8130049982&start_time=2022-12-01T00:00:00%2b00:00&end_time=2024-10-30T00:00:00%2b00:00&output=csv&fields=lake_id,time_str,wse,ds1_l,p_storage'
{"status":"200 OK","time":364.788,"hits":3,"results":{"csv":"lake_id,time_str,wse,ds1_l,p_storage,wse_units,ds1_l_units,p_storage_units\n8130049982,no_data,-999999999999.0,-999999999999.0,-999999999999.0,m,km^3,km^3\n8130049982,2024-08-24T04:37:29Z,28.31,-999999999999.0,-999999999999.0,m,km^3,km^3\n8130049982,2024-08-25T04:38:09Z,29.053,-999999999999.0,-999999999999.0,m,km^3,km^3\n","geojson":{}}}

BENCHMARK TESTS RUN

Screenshot 2024-10-09 at 11 36 20

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@nikki-t nikki-t requested review from jamesfwood and torimcd October 9, 2024 15:43
@nikki-t nikki-t self-assigned this Oct 9, 2024
@nikki-t nikki-t requested a review from ymchenjpl October 9, 2024 15:46
@nikki-t nikki-t requested a review from frankinspace October 9, 2024 16:56
@nikki-t nikki-t merged commit 7d8fd12 into main Oct 10, 2024
1 check passed
@nikki-t nikki-t deleted the release/1.5.0 branch October 10, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants