Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled expat version 2.6.3 #4683

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Bundled expat version 2.6.3 #4683

merged 1 commit into from
Sep 25, 2024

Conversation

matejk
Copy link
Contributor

@matejk matejk commented Sep 12, 2024

Security fixes.

Fixes #4123.

https://github.com/libexpat/libexpat/blob/R_2_6_3/expat/Changes

#887 #890  CVE-2024-45490 -- Calling function XML_ParseBuffer with
                len < 0 without noticing and then calling XML_GetBuffer
                will have XML_ParseBuffer fail to recognize the problem
                and XML_GetBuffer corrupt memory.
                With the fix, XML_ParseBuffer now complains with error
                XML_ERROR_INVALID_ARGUMENT just like sibling XML_Parse
                has been doing since Expat 2.2.1, and now documented.
                Impact is denial of service to potentially artitrary code
                execution.
   #888 #891  CVE-2024-45491 -- Internal function dtdCopy can have an
                integer overflow for nDefaultAtts on 32-bit platforms
                (where UINT_MAX equals SIZE_MAX).
                Impact is denial of service to potentially artitrary code
                execution.
   #889 #892  CVE-2024-45492 -- Internal function nextScaffoldPart can
                have an integer overflow for m_groupSize on 32-bit
                platforms (where UINT_MAX equals SIZE_MAX).
                Impact is denial of service to potentially artitrary code
                execution.

Copy link
Member

@obiltschnig obiltschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes seem to be missing. E.g., the version number in expat.h and expat_config.h have not been updated. Also, winconfig.h is not needed. The changes in xmlrole.c and xmltok.c are not needed.

For reference, compare the expat release with the previous one.

@matejk matejk force-pushed the expat_version_2.6.3 branch from 0513590 to 9a7da6d Compare September 25, 2024 14:44
@matejk
Copy link
Contributor Author

matejk commented Sep 25, 2024

Some changes seem to be missing. E.g., the version number in expat.h and expat_config.h have not been updated. Also, winconfig.h is not needed. The changes in xmlrole.c and xmltok.c are not needed.

For reference, compare the expat release with the previous one.

I corrected all files except expat_config.h which doesn't seem to contain expat version info.

@matejk matejk requested a review from obiltschnig September 25, 2024 14:47
Copy link
Member

@obiltschnig obiltschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obiltschnig obiltschnig merged commit 3a8c6a7 into main Sep 25, 2024
43 checks passed
@matejk matejk deleted the expat_version_2.6.3 branch September 26, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

DoS vulnerability in XML/src/xmlparse.cpp
3 participants