Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving operator<< and operator>> overloads into the Poco::Net namespace. #4491

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Moving operator<< and operator>> overloads into the Poco::Net namespace. #4491

merged 1 commit into from
Mar 28, 2024

Conversation

andrewauclair
Copy link
Contributor

Addresses the issues in #3997.

@andrewauclair
Copy link
Contributor Author

Looks like I missed something. I'll investigate why gcc doesn't like this.

@andrewauclair andrewauclair force-pushed the insertion-operator-adl branch from aeef500 to c3281a4 Compare March 13, 2024 00:16
@andrewauclair andrewauclair force-pushed the insertion-operator-adl branch from c3281a4 to b29420c Compare March 13, 2024 00:20
@andrewauclair
Copy link
Contributor Author

The issue was the operator<< for MacAddress. I forgot that MacAddress is just an alias of std::vector<unsigned char>. Now that I see this, I think it's a bit wrong for Poco to define a operator<< for std::vector<unsigned char>.

@aleks-f aleks-f merged commit 47c4f07 into pocoproject:devel Mar 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewauclair @aleks-f