Modify validation check in Poco::DateTime #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be great if the exception could say what part of the date is wrong, or include the formatted date as part of the exception text. Also, please fix the exception text ("DataTime"). |
|
@obiltschnig Thank you for your comments. |
|
I've fixed exception message. |
|
Are you planning to merge this into the main branch? The bug is still in 1.13.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear, developers.
I tried improved validation check in
Poco::DateTimeandPoco::DateTime.assignaccording to issues #1540's ideas.I modified that used exception(InvalidArgumentException) in place of
poco_assert.