fix(Net): HTTPCookie Constructor Fails to Handle Discard Attribute Pr…

…operly (#4664)
pocoproject · Sep 26, 2024 · db1cc95 · db1cc95
1 parent 42ccb0d
commit db1cc95
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/Net/src/HTTPCookie.cpp b/Net/src/HTTPCookie.cpp
@@ -119,7 +119,7 @@ HTTPCookie::HTTPCookie(const NameValueCollection& nvc):
 		{
 			setHttpOnly(true);
 		}
-		else
+		else if (_name.empty())
 		{
 			setName(name);
 			setValue(value);

diff --git a/Net/testsuite/src/HTTPCookieTest.cpp b/Net/testsuite/src/HTTPCookieTest.cpp
@@ -192,6 +192,22 @@ void HTTPCookieTest::testCookieExpiry(DateTime expiryTime)
 }
 
 
+void HTTPCookieTest::testIgnoreExtraAttributes()
+{
+	NameValueCollection nvc;
+	nvc.add("test", "foo");
+	nvc.add("Version", "1");
+	nvc.add("Path", "/test/path");
+	nvc.add("Discard", "");
+	nvc.add("HttpOnly", "");
+
+	HTTPCookie cookie(nvc);
+	assert (cookie.getName() == "test");
+	assert (cookie.getValue() == "foo");
+	assert (cookie.getHttpOnly());
+}
+
+
 void HTTPCookieTest::setUp()
 {
 }
@@ -211,6 +227,7 @@ CppUnit::Test* HTTPCookieTest::suite()
 	CppUnit_addTest(pSuite, HTTPCookieTest, testUnescape);
 	CppUnit_addTest(pSuite, HTTPCookieTest, testExpiryFuture);
 	CppUnit_addTest(pSuite, HTTPCookieTest, testExpiryPast);
+	CppUnit_addTest(pSuite, HTTPCookieTest, testIgnoreExtraAttributes);
 
 	return pSuite;
 }
diff --git a/Net/testsuite/src/HTTPCookieTest.h b/Net/testsuite/src/HTTPCookieTest.h
@@ -31,6 +31,7 @@ class HTTPCookieTest: public CppUnit::TestCase
 	void testExpiryFuture();
 	void testExpiryPast();
 	void testCookieExpiry(Poco::DateTime expiryTime);
+	void testIgnoreExtraAttributes();
 
 	void setUp();
 	void tearDown();