Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup in react followed drag and drop grid. fixes #5365 #5366

Merged

Conversation

Adam-it
Copy link
Member

@Adam-it Adam-it commented Jan 3, 2025

What's in this Pull Request?

As the current solution seems to stop working i refactored the webpart not to use MS Graph but SP Rest API to get followed sites.
The rest was not changed

Result

image

image

@hugoabernier
Copy link
Collaborator

Hey @Adam-it thank you for this update. I'm having a real hard time getting the npm install for this web part to work. What version of node did you use for this?

Also, I know a really cool guy that started this ranger initiative to encourage people to upgrade their web parts to SPFx 1.20... maybe you know him? 😉

@Adam-it
Copy link
Member Author

Adam-it commented Jan 14, 2025

Hey @Adam-it thank you for this update. I'm having a real hard time getting the npm install for this web part to work. What version of node did you use for this?

Also, I know a really cool guy that started this ranger initiative to encourage people to upgrade their web parts to SPFx 1.20... maybe you know him? 😉

I think I use v12. Both v14 and v12 Node.js versions should work.
I may Upgrade it to the latest SPFx version but maybe as a separate PR. This sample is not that popular so I am not sure there is great benefit in this, and currently I would not find time for that 🙂

@hugoabernier hugoabernier merged commit d5d468f into pnp:main Jan 15, 2025
3 checks passed
@hugoabernier
Copy link
Collaborator

Many thanks @Adam-it for your update! Much appreciated!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-followed-drag-and-drop-grid -
3 participants