Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge for 1.20.0 release #660

Merged
merged 102 commits into from
Sep 9, 2020
Merged
Changes from 1 commit
Commits
Show all changes
102 commits
Select commit Hold shift + click to select a range
4576359
Opts LIPicker substringof + Attachments new window
joeljeffery Jun 13, 2020
5d6d862
Map control displayname and address details
joeljeffery Jun 14, 2020
704172d
typing on coordinates object
joeljeffery Jun 14, 2020
8d3a406
Rudimentary Bing Map support
joeljeffery Jun 14, 2020
7a468ea
Zoom multiplier bug - div/0 whoops! :)
joeljeffery Jun 14, 2020
c31ce7f
1.20.0
estruyf Jun 17, 2020
62f4754
Fix of #569 - correctly working itemLimit prop
AJIXuMuK Jun 21, 2020
e1d2ec5
changelog
AJIXuMuK Jun 21, 2020
b842f36
Add FieldCollectionData control.
Jun 23, 2020
45d45f6
Merge pull request #591 from siata13/dev
AJIXuMuK Jun 24, 2020
d3e5d5f
changelog
AJIXuMuK Jun 24, 2020
665de9f
updated references for lodash to work correctly in SP 2016
AJIXuMuK Jun 24, 2020
e4eb553
Merge pull request #592 from pnp/sp2016
AJIXuMuK Jun 24, 2020
0f00975
changelog
AJIXuMuK Jun 24, 2020
c014a30
Add StockImages to FilePicker
Jun 29, 2020
fe9fd76
Updated changelog + verified filepicker
estruyf Jun 29, 2020
bf1fc53
Updated changelog
estruyf Jun 29, 2020
7ead252
Merge branch 'siata13-dev' into dev
estruyf Jun 29, 2020
e6edc48
Fix of #216: ability to set required property and error message for t…
AJIXuMuK Jul 3, 2020
c82e764
Merge branch 'dev' into 216
AJIXuMuK Jul 3, 2020
b6f6a7e
Merge pull request #600 from pnp/216
AJIXuMuK Jul 3, 2020
07cf6c4
changelog
AJIXuMuK Jul 3, 2020
3ca4f6a
fix of #477
AJIXuMuK Jul 4, 2020
72ae594
changelog
AJIXuMuK Jul 4, 2020
956b434
small doc fix for taxonomy picker
AJIXuMuK Jul 4, 2020
aecd5d5
one more doc fix for taxonomy picker
AJIXuMuK Jul 4, 2020
bd0edbd
Fix of #590 - showRequiredError prop is added
AJIXuMuK Jul 4, 2020
c8634be
changelog
AJIXuMuK Jul 4, 2020
56b0505
merge with dev
AJIXuMuK Jul 6, 2020
5aed5dd
react lifecycle is back
AJIXuMuK Jul 6, 2020
a87d2e1
map coordinates fix
AJIXuMuK Jul 7, 2020
39cceca
documentation for the changes
AJIXuMuK Jul 7, 2020
97a9359
Merge branch 'joeljeffery-master' into dev
AJIXuMuK Jul 7, 2020
bc8ba0a
changelog
AJIXuMuK Jul 7, 2020
287b069
Specifies if the initial values will be validated, when the component…
geltapatio Jul 7, 2020
933d92b
Suggestions/match returns the correct results
geltapatio Jul 9, 2020
599252a
#609 Fix invalid invocation of Carousel handlers.
Jul 10, 2020
a24e895
Merge pull request #610 from siata13/dev
AJIXuMuK Jul 10, 2020
ec47619
changelog
AJIXuMuK Jul 10, 2020
e795e5b
TaxonomyPicker: no suggestions if anchorId is not set
AJIXuMuK Jul 11, 2020
1f2280a
changelog
AJIXuMuK Jul 11, 2020
10750d4
updates to cache correct values
AJIXuMuK Jul 12, 2020
2400ad4
Merge branch 'geltapatio-604-Pnp-TaxonomyPicker-suggestion-dont-work-…
AJIXuMuK Jul 12, 2020
9376d83
changelog
AJIXuMuK Jul 12, 2020
f4316c4
Merge branch '602-Pnp-Taxonomy-Picker-onload-validation' of https://g…
AJIXuMuK Jul 12, 2020
df16dd5
Correct validation and text localization
AJIXuMuK Jul 12, 2020
83f598d
Merge branch 'geltapatio-602-Pnp-Taxonomy-Picker-onload-validation' i…
AJIXuMuK Jul 12, 2020
f936742
changelog
AJIXuMuK Jul 12, 2020
0b97b4b
Error message will be always displayed if validateOnLoad is set to tr…
AJIXuMuK Jul 14, 2020
914e4fd
Add pagining and filtering for FieldCollectionData
Jul 21, 2020
6df1af8
Merge pull request #617 from siata13/dev
AJIXuMuK Jul 26, 2020
8c178f0
changelog
AJIXuMuK Jul 26, 2020
ef74ed1
Include check for separator while filtering path of terms when anchor…
Jul 30, 2020
03846e3
Small markup changed
estruyf Jul 31, 2020
f6108e1
Small markup changed
estruyf Jul 31, 2020
642a5ae
Merge branch 'devangbhavsar89-dev' into dev
estruyf Jul 31, 2020
6871613
Updated changelog
estruyf Jul 31, 2020
6ea9ba2
Added correction that taxonomy picker crashed when SharePoint return …
Aug 12, 2020
45834b7
Implemented change on suggestion to allow searching on alternative la…
Aug 12, 2020
c960b31
Fix Bing API search issue
gautamdsheth Aug 14, 2020
3624856
Merge pull request #633 from gautamdsheth/bugfix/bing-API-Issue
AJIXuMuK Aug 14, 2020
ddd4812
Merge branch 'dev' of https://github.com/TheThor59/sp-dev-fx-controls…
AJIXuMuK Aug 14, 2020
d2d910f
semicolons
AJIXuMuK Aug 14, 2020
645cec6
Merge branch 'TheThor59-dev' into dev
AJIXuMuK Aug 14, 2020
4d952a8
changelog
AJIXuMuK Aug 14, 2020
b7e5e6b
fix of #621 ListView Sort Fires Selection
AJIXuMuK Aug 15, 2020
ab4bf01
changelog
AJIXuMuK Aug 15, 2020
4299eeb
support of additional file formats for FileTypeIcon in Image mode
AJIXuMuK Aug 22, 2020
49f33bc
Merge pull request #640 from pnp/additional-formats
AJIXuMuK Aug 22, 2020
9326643
changelog
AJIXuMuK Aug 22, 2020
1a6b69c
Update Map.tsx
anoopt Aug 23, 2020
5d04223
#638 - Changes to make the new Accordion control work in v1
estruyf Aug 24, 2020
079ba38
#638 - Documentation added
estruyf Aug 24, 2020
302c223
Updated changelog + version
estruyf Aug 24, 2020
57069af
Merge pull request #641 from anoopt/maps-minor-update
AJIXuMuK Aug 25, 2020
da5e867
changelog
AJIXuMuK Aug 25, 2020
f25337d
fix of #615
AJIXuMuK Aug 25, 2020
e580dc8
changelog
AJIXuMuK Aug 25, 2020
33b5eae
fix of #614
AJIXuMuK Aug 25, 2020
a2a06a0
correct documentation for `FolderPicker` import
AJIXuMuK Aug 25, 2020
b88a9f2
changelog
AJIXuMuK Aug 25, 2020
c0d3726
Small accordion change
estruyf Aug 26, 2020
9a1966b
Merge branch 'dev' of github.com:SharePoint/sp-dev-fx-controls-react …
estruyf Aug 26, 2020
425f53a
fix of #596
AJIXuMuK Aug 27, 2020
92f6ae5
changelog
AJIXuMuK Aug 27, 2020
ae87fae
Fix #644 - escape single quote in folder explorer
gautamdsheth Aug 28, 2020
63a493e
Merge pull request #645 from gautamdsheth/bugfix/644-single-quote-issue
AJIXuMuK Aug 28, 2020
1b1550e
changelog
AJIXuMuK Aug 28, 2020
f8df13b
code of conduct
AJIXuMuK Aug 28, 2020
b3e253d
code of conduct section header
AJIXuMuK Aug 28, 2020
b77ad17
people picker imageUrl was resolved by user email, when it should be …
Aug 31, 2020
a3714ee
people picker imageUrl was resolved by user email, when it should be …
Aug 31, 2020
1a6ff3c
people picker imageUrl was resolved by user email, when it should be …
Aug 31, 2020
d201206
people picker imageUrl was resolved by user email, when it should be …
Aug 31, 2020
5079899
Merge pull request #646 from juhaalhojoki/fix/peopleSearchService-ima…
AJIXuMuK Sep 2, 2020
52e4e9f
changelog
AJIXuMuK Sep 2, 2020
de9607b
Update IconPicker.md
ravichandran-blog Sep 2, 2020
b13e1df
Merge branch 'patch-1' of https://github.com/ravichandran-blog/sp-dev…
AJIXuMuK Sep 3, 2020
03c26a1
Merge branch 'ravichandran-blog-patch-1' into dev
AJIXuMuK Sep 3, 2020
fe0907a
changelog
AJIXuMuK Sep 3, 2020
c52d0d0
Updated changelog
estruyf Sep 9, 2020
81a0840
Version update
estruyf Sep 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
react lifecycle is back
  • Loading branch information
AJIXuMuK committed Jul 6, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 5aed5dd8a3b54d4959cc69b3daa9886c69c5d2d6
22 changes: 10 additions & 12 deletions src/controls/map/Map.tsx
Original file line number Diff line number Diff line change
@@ -33,8 +33,7 @@ export class Map extends React.Component<IMapProps, IMapState> {
/**
* componentWillMount lifecycle hook
*/
// 20200614 - legacy react lifecycle event; use constructor instead
// public componentWillMount(): void {
// public componentWillMount(): void {
// this.setState({
// coordinates: this.props.coordinates
// });
@@ -43,14 +42,13 @@ export class Map extends React.Component<IMapProps, IMapState> {
/**
* componentWillUpdate lifecycle hook
*/
// 20200614 - legacy react lifecycle event; don't use
// public componentWillUpdate(nextProps: IMapProps, nextState: IMapState): void {
// if (!isEqual(this.props.coordinates, nextProps.coordinates)) {
// this.setState({
// coordinates: this.props.coordinates
// });
// }
// }
public componentWillUpdate(nextProps: IMapProps, nextState: IMapState): void {
if (!isEqual(this.props.coordinates, nextProps.coordinates)) {
this.setState({
coordinates: this.props.coordinates
});
}
}

/**
* Get the dif value based on zoom supplied (dif is for calculating the 4 corners of the map)
@@ -59,7 +57,7 @@ export class Map extends React.Component<IMapProps, IMapState> {
const { zoom } = this.props;
// 20200614 - JJ - support zoom levels beyond 15
const newZoom: number = zoom >= 0 ? zoom % 16 : 10;
const multiplier = Math.floor(zoom / 16) + 1;
const multiplier = Math.floor(zoom / 16) + 1;
return (0.0025 + (0.005 * (15 - (newZoom))))/multiplier;
}

@@ -205,7 +203,7 @@ export class Map extends React.Component<IMapProps, IMapState> {
* Default React render method
*/
public render(): React.ReactElement<IMapProps> {
const { mapSource } = this.props;
const { mapSource } = this.props;
let width: string = this._getWidth();
let height: number = this._getHeight();
let mapUrl: string = ["BingDraggable", "BingStatic"].indexOf(mapSource) !== -1 ? this._getBingMapUrl(width, height) : this._getMapUrl(); //20200614 - JJ - rudimentary bing map support (draggable/static) with pushpin (static only)