Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is month picker visible not respected #284

Merged
merged 1 commit into from
May 17, 2019

Conversation

robert-lindstrom
Copy link
Contributor

@robert-lindstrom robert-lindstrom commented Apr 26, 2019

Q A
Bug fix? [X]
New feature? [ ]
New sample? [ ]
Related issues? fixes #283

What's in this Pull Request?

Fixes problem with DateTimePicker not respecting the isMonthPickerVisible prop. This PR fixes that by passing on the isMonthPickerVisible prop to the underlying DatePicker

@codecov-io
Copy link

Codecov Report

Merging #284 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   72.33%   72.36%   +0.03%     
==========================================
  Files          17       17              
  Lines         759      760       +1     
  Branches      156      147       -9     
==========================================
+ Hits          549      550       +1     
  Misses        163      163              
  Partials       47       47
Impacted Files Coverage Δ
src/common/telemetry/version.ts 100% <ø> (ø) ⬆️
src/controls/webPartTitle/WebPartTitle.tsx 86.95% <100%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d85b4...6d5d7e1. Read the comment docs.

@robert-lindstrom robert-lindstrom changed the base branch from master to dev May 15, 2019 15:40
@estruyf estruyf merged commit 6d5d7e1 into pnp:dev May 17, 2019
@estruyf
Copy link
Member

estruyf commented May 17, 2019

@robert-lindstrom thanks for this fix, it will be included in 1.8.2

@estruyf estruyf added this to the 1.13.2 milestone May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants