Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #1511 #1512

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Fix for #1511 #1512

merged 1 commit into from
Apr 18, 2023

Conversation

wuxiaojun514
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

This PR is the hotfix for #1511 .
It just change SPService.ts to use ${lookupFieldName || 'Title'} instead of Title for Lookup Field.

Guidance

  • You can delete this section when you are submitting the pull request.
  • Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
  • Please target your PR to dev branch.

@AJIXuMuK AJIXuMuK merged commit 29c64d7 into pnp:dev Apr 18, 2023
@AJIXuMuK AJIXuMuK added this to the 3.14.0 milestone Apr 18, 2023
@AJIXuMuK
Copy link
Collaborator

Thank you @wuxiaojun514 for the fix!

@wuxiaojun514 wuxiaojun514 deleted the 1511 branch October 17, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wuxiaojun514 @AJIXuMuK