-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'AdaptiveCardDesignerHost' Control #1238
Conversation
@fabiofranzini another awesome PR 😁 |
@joelfmrodrigues tell me if you need a call to understand all refactored code of "AdaptiveCardHost" control. |
src/controls/adaptiveCardDesignerHost/fluentUI/AdaptiveCardHostContainer.ts
Outdated
Show resolved
Hide resolved
I really-really-really sorry @fabiofranzini for the long delay. |
Don't worries and thanks for your review! I'm on vacation now, I'll try to do that fixes in the next few days. Thanks again |
@AJIXuMuK I've closed all change requests 🙂 |
Thanks @fabiofranzini! |
@AJIXuMuK done! Thanks for another code review! 🙂 |
What's in this Pull Request?
Implementation of the Adaptive Card Designer control as reusable react control.
To better implement this control and avoid code duplication, I had to refactor the "Adaptive Card Host" control due to share more code between the 'AdaptiveCardHost' and 'AdaptiveCardHostDesigner' controls.
I deleted the Fluent UI themes that were previously local to the 'AdaptiveCardHost' control and reused those placed in the 'common' folder, to use the latest version of the Teams theme implementations, used by the 'EnhancedThemeProvider' control.
Given the nature of the refactoring, I'm available for any clarifications.
Thanks!