Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Richtext control, can not undo ordered lists #1135

Closed
tobysroof opened this issue Feb 21, 2022 · 7 comments · Fixed by #1863
Closed

Richtext control, can not undo ordered lists #1135

tobysroof opened this issue Feb 21, 2022 · 7 comments · Fixed by #1863
Assignees
@Ateina
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone
3.19.0

Comments

@tobysroof
Copy link

Category

[ ] Enhancement

[X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 3.6.0 ]

Expected / Desired Behavior / Question

When using the RichText Component, when selecting a ordered (numbered) list, and then clicking the ordered list control, we expect the numbered list to be unmade. (this works for unordered lists)

Observed Behavior

When selecting a numbered list in a richtext component, and then clicking the numbered list control, the numbered list is unaffected.

Steps to Reproduce

Using the richtext control. Add some lines and then make them into a ordered list by selecting the text and clicking the ordered list option. Click the same option again to "unmake" the list. Note that nothing happens.

Do the same thing with a unordered list and note that the unordered list is "unmade" correctly
@ghost
Copy link

ghost commented Feb 21, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Feb 21, 2022
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@joelfmrodrigues
Copy link
Collaborator

Hi @tobysroof many thanks for reporting the issue. Would you be interested in trying to fix it and submit a pull request?

@Ateina
Copy link
Contributor

Ateina commented Apr 9, 2024 •
edited
Loading

Hi @joelfmrodrigues, @michaelmaillot!
I think I found the reason for this bug, I can create a PR for it
could you assign this issue to me?

@michaelmaillot
Copy link
Collaborator

Hi @Ateina,

Sure, it's all yours!

@michaelmaillot michaelmaillot added the status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. label Apr 17, 2024
Ateina added a commit to Ateina/sp-dev-fx-controls-react that referenced this issue Apr 17, 2024
@Ateina
pnp#1135: fix keys for ordered list
e8324af
@Ateina Ateina mentioned this issue Apr 17, 2024
Merged
@Ateina
Copy link
Contributor

Ateina commented Apr 17, 2024

@michaelmaillot Thank you!

michaelmaillot pushed a commit that referenced this issue Aug 10, 2024
@Ateina
#1135: Richtext control, can not undo ordered lists (#1807)
a17a823 
* #1135: fix keys for ordered list

* #1101: fix issue with adding link by typing in FilePicker "From a link" tab

* Revert "#1101: fix issue with adding link by typing in FilePicker "From a link" tab"

This reverts commit e2afed6.

Revert "#1101: fix issue with adding link by typing in FilePicker "From a link" tab"

This reverts commit e2afed6.
@michaelmaillot michaelmaillot added status:fixed-next-drop Issue will be fixed in upcoming release. and removed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. labels Aug 10, 2024
@michaelmaillot michaelmaillot added this to the 3.19.0 milestone Aug 10, 2024
@michaelmaillot
Copy link
Collaborator

Linked PR has been merged, the fix should be available in the next beta release.

michaelmaillot added a commit that referenced this issue Aug 10, 2024
@michaelmaillot
Updating changelog following PR #1135 merged
a1270d0
@AJIXuMuK AJIXuMuK mentioned this issue Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ateina Ateina

Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Milestone
3.19.0
Development

Successfully merging a pull request may close this issue.

Dev 3.19.0 pnp/sp-dev-fx-controls-react
4 participants
@tobysroof @Ateina @joelfmrodrigues @michaelmaillot