[BUG FIX] Let pngpriv.h control all architecture optimizations #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jbowler
commented
Oct 9, 2024
- cmake: Remove architecture-specific checks for hardware optimization
- configure: Remove architecture-specific checks for hardware optimization
This mirrors the CMakeLists.txt improvements in configure.ac and Makefile.am. The complex compiler check is removed from Loongarch so that it is done the same way as everything else along with the curious use of a library in Makefile.am (never done in CMakeLists.txt) The hard-disable of the Intel SSE optimizations done in libpng1.6 to ensure that the configure options did not change mid-version is now removed so the SSE optimizations are on by default (change already made in 1.6 CMakeLists.txt but not configure.) Signed-off-by: John Bowler <jbowler@acm.org>
|
@ctruta: this is good to go. All my tests pass. |
|
Integrated in branch 'libpng18'. |
|
Excellent! Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.