Skip to content

Commit

Permalink
Stop using the deprecated attr.single_file.
Browse files Browse the repository at this point in the history
  • Loading branch information
pmuetschard committed Jun 21, 2019
1 parent 41bc25f commit cf6f4d0
Show file tree
Hide file tree
Showing 11 changed files with 18 additions and 24 deletions.
3 changes: 1 addition & 2 deletions gapidapk/android/apk/rules.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ _strip = rule(
implementation = _strip_impl,
attrs = {
"lib": attr.label(
single_file = True,
allow_files = True,
allow_single_file = True,
mandatory = True,
),
"abi": attr.string(),
Expand Down
3 changes: 1 addition & 2 deletions tools/build/rules/cc.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ _symbols = rule(
_symbols_impl,
attrs = {
"src": attr.label(
allow_files = True,
single_file = True,
allow_single_file = True,
),
"_dump_syms": attr.label(
executable = True,
Expand Down
3 changes: 1 addition & 2 deletions tools/build/rules/common.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ copy = rule(
_copy_impl,
attrs = {
"src": attr.label(
single_file = True,
allow_files = True,
allow_single_file = True,
mandatory = True,
),
"dst": attr.output(),
Expand Down
3 changes: 1 addition & 2 deletions tools/build/rules/filehash.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ filehash = rule(
),
"template": attr.label(
mandatory = True,
single_file = True,
allow_files = True,
allow_single_file = True,
),
"replace": attr.string(mandatory = True),
"out": attr.output(mandatory = True),
Expand Down
6 changes: 2 additions & 4 deletions tools/build/rules/gapil.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ api_library = rule(
attrs = {
"apiname": attr.string(mandatory=True),
"api": attr.label(
single_file = True,
allow_files = True,
allow_single_file = True,
),
"includes": attr.label_list(allow_files = True),
"deps": attr.label_list(
Expand Down Expand Up @@ -68,8 +67,7 @@ api_template = rule(
_api_template_impl,
attrs = {
"template": attr.label(
single_file = True,
allow_files = True,
allow_single_file = True,
),
"includes": attr.label_list(allow_files = True),
"outputs": attr.string_list(),
Expand Down
3 changes: 1 addition & 2 deletions tools/build/rules/repository.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@

_BUILD_FILE_ATTRS = {
"build_file": attr.label(
allow_files = True,
single_file = True,
allow_single_file = True,
),
"build_file_content": attr.string(),
}
Expand Down
3 changes: 1 addition & 2 deletions tools/build/rules/stringgen.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ stringgen = rule(
_stringgen_impl,
attrs = {
"input": attr.label(
single_file = True,
allow_files = True,
allow_single_file = True,
mandatory = True,
),
"_stringgen": attr.label(
Expand Down
3 changes: 1 addition & 2 deletions tools/build/rules/zip.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ extract = rule(
_extract_impl,
attrs = {
"zip": attr.label(
single_file = True,
allow_files = True,
allow_single_file = True,
mandatory = True,
),
"entries": attr.string_list(mandatory=True),
Expand Down
3 changes: 1 addition & 2 deletions tools/build/third_party/breakpad.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ breakpad = repository_rule(
"commit": attr.string(mandatory = True),
"build_file": attr.label(
mandatory = True,
allow_files = True,
single_file = True,
allow_single_file = True,
),
},
)
3 changes: 1 addition & 2 deletions tools/build/third_party/llvm/rules.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,7 @@ llvm_tablegen = rule(
_tablegen_impl,
attrs = {
"table": attr.label(
single_file = True,
allow_files = True,
allow_single_file = True,
),
"deps": attr.label_list(allow_files = True),
"generate": attr.output(),
Expand Down
9 changes: 7 additions & 2 deletions version.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,13 @@ def _gapid_version(ctx):
gapid_version = rule(
implementation=_gapid_version,
attrs = {
"template": attr.label(mandatory = True, allow_files = True, single_file = True),
"out": attr.output(mandatory = True),
"template": attr.label(
mandatory = True,
allow_single_file = True,
),
"out": attr.output(
mandatory = True,
),
},
output_to_genfiles = True,
)

0 comments on commit cf6f4d0

Please sign in to comment.