-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dev dependencies #2830
Changes from 3 commits
8f1f12d
992e263
a313108
23e3933
703ae84
a61a9ea
d526af4
260aca4
fb3f6b1
e8914ba
d7c46c2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -136,19 +136,19 @@ | |
"@types/node": "^22.9.0", | ||
"@types/react": "^18.3.12", | ||
"@types/react-dom": "^18.3.1", | ||
"@typescript-eslint/eslint-plugin": "^8.13.0", | ||
"@typescript-eslint/parser": "^8.13.0", | ||
"@vitest/coverage-v8": "^2.1.4", | ||
"@vitest/eslint-plugin": "^1.1.8", | ||
"@vitest/ui": "^2.1.4", | ||
"@typescript-eslint/eslint-plugin": "^8.14.0", | ||
"@typescript-eslint/parser": "^8.14.0", | ||
"@vitest/coverage-v8": "^2.1.5", | ||
"@vitest/eslint-plugin": "^1.1.10", | ||
"@vitest/ui": "^2.1.5", | ||
"benny": "^3.7.1", | ||
"downlevel-dts": "^0.11.0", | ||
"esbuild": "^0.24.0", | ||
"eslint": "8.57.0", | ||
"eslint-config-prettier": "^9.1.0", | ||
"eslint-import-resolver-alias": "^1.1.2", | ||
"eslint-plugin-import": "^2.31.0", | ||
"eslint-plugin-jest-dom": "^5.4.0", | ||
"eslint-plugin-jest-dom": "^5.5.0", | ||
"eslint-plugin-prettier": "^5.2.1", | ||
"eslint-plugin-react": "^7.37.2", | ||
"eslint-plugin-react-compiler": "19.0.0-beta-a7bf2bd-20241110", | ||
|
@@ -158,17 +158,17 @@ | |
"jsdom": "^25.0.1", | ||
"json": "^11.0.0", | ||
"prettier": "^3.3.3", | ||
"react": "19.0.0-rc.0", | ||
"react-dom": "19.0.0-rc.0", | ||
"rollup": "^4.25.0", | ||
"react": "19.0.0-rc.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updating react to rc.1 makes tests to fail. @kretajak I wonder if you are familiar with this case. Do we misuse RTL for async tests? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will take a look at that. The way RTL is used here to test async stuff is fine from my perspective. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like broken tests are using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for taking a look. I know the Suspense behavior was changed, but didn't consider if it really broke it. https://stackblitz.com/edit/vitejs-vite-hbi7w9?file=src%2FApp.tsx&terminal=dev This looks like working. So, it's probably test only issue. |
||
"react-dom": "19.0.0-rc.1", | ||
"rollup": "^4.27.2", | ||
"rollup-plugin-banner2": "^1.3.0", | ||
"rollup-plugin-esbuild": "^6.1.1", | ||
"rxjs": "^7.8.1", | ||
"shelljs": "^0.8.5", | ||
"shx": "^0.3.4", | ||
"ts-expect": "^1.3.0", | ||
"typescript": "^5.6.3", | ||
"vitest": "^2.1.4", | ||
"vitest": "^2.1.5", | ||
"wonka": "^6.3.4" | ||
}, | ||
"peerDependencies": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the list of commits for the change:
facebook/react@5c56b87...e1ef8c9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More precisely, it's between these commit that cause the error:
facebook/react@380f5d6...b01722d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So,
enableSiblingPrerendering
should only be the meaningful change.