Fix/flush pending finally everywhere 2 #2817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…#2805) * Update location.mdx Added an important warning note against instantiating `atomWithLocation` more than once in an app * ran `prettier` npm script and added 2 `code` annotations for the new paragraph
* fix(unstable_derive): expose atomRead and atomWrite * Fix/unstable derive - add more tests (pmndrs#2751) * fix(unstable_derive): add tests * test(unstable_derive): add failing test * remove originAtomState * feat: atomOnMount * adjust test * is this too naive? * Update src/vanilla/store.ts Co-authored-by: David Maskasky <dmaskasky@otter.ai> --------- Co-authored-by: David Maskasky <dmaskasky@otter.ai>
* Fix undefined or null atoms * Simplify conditional, only in dev mode Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com> * Update useSetAtom.ts * move warning to store.ts * move the warning in getAtomState --------- Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com> Co-authored-by: daishi <daishi@axlight.com>
* fix(utils): make 'loadable' update immediate after resolve * fix comments in pmndrs#2790 --------- Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
e9a6b08 to
67b55c1
Compare
|
Rebase issue, now i'm seeing too many commits, and unrelated changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
Expands on #2816
Summary
Adds test cases for every error case.
Check List
cfor formatting code and docs