Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix typescript errors in trail story #1783

Merged

Conversation

cjnix35
Copy link
Contributor

@cjnix35 cjnix35 commented Jan 15, 2024

Why

I've updated the trail story to improve code clarity and align better with TypeScript and React standards. Fixed some type mismatches, removed the @ts-ignore for clearer code, and refactored the UseTrailScene for better readability. These changes resolve TypeScript errors and enhance overall code quality.

What

  1. Changing type references from Mesh to Group in appropriate places.
  2. Removing @ts-ignore and implementing destructuring for trailPositions.current.slice.
  3. Refactoring the UseTrailScene component to be more in line with React standards and improving readability.
  4. Ensuring all TypeScript errors are resolved with these changes.

Checklist

  • Ready to be merged

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 4:43pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 30af966:

Sandbox Source
zen-cache-vyd4w6 Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@drcmda drcmda merged commit 4ed9840 into pmndrs:master Jan 30, 2024
2 checks passed
Copy link

🎉 This PR is included in version 9.97.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants