Improve deobfuscateAppleGPU #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7da7d92 to
1695891
Compare
- include missing chipsets that support ios >= 13 - when magic pixel value is missing in our lookup, default to both newer and older models
- with multiple results of the same resolution, pick the one with the lowest fps - when apple's fixing of deobfuscation is detected, eliminate all devices that do not support ios 14.x - export ipad benchmark data seperately allows client code simplifications - extract apple deobfuscation pixel logic - refactor all outer anonymous arrow function to named functions - throw when benchmark data is out of date - bump major version
164c3c9 to
00b4c61
Compare
| @@ -1,4 +1,4 @@ | |||
| export const getGPUVersion = (model: string) => { | |||
| export function getGPUVersion(model: string) { | |||
There was a problem hiding this comment.
Are the const to function changes stylistic or do they serve a purpose?
There was a problem hiding this comment.
The primary difference between function declarations and function expressions is that declarations are hoisted to the top of the scope in which they are defined, which allows you to write code that uses the function before its declaration.
(I can revert if wanted)
|
Sorry for bothering you guys, but is there any chance to get this PR merged? |
…-gpu into chore/improve-ios-deobfuscation # Conflicts: # benchmarks.tar.gz # benchmarks/d-adreno.json # benchmarks/d-amd.json # benchmarks/d-apple.json # benchmarks/d-geforce.json # benchmarks/d-intel.json # benchmarks/d-nvidia.json # benchmarks/d-radeon.json # benchmarks/m-adreno.json # benchmarks/m-apple.json # benchmarks/m-intel.json # benchmarks/m-mali-t.json # benchmarks/m-mali.json # benchmarks/m-nvidia.json # benchmarks/m-powervr.json # package.json
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #77