Skip to content

Commit

Permalink
Revert puppeteer back to previous version ^13.0.0 in order to fix iss…
Browse files Browse the repository at this point in the history
…ue with weekly automated benchmarks update

Newer versions of puppeteer install chrome to a directory the github action cannot access, causing it to fail while running update_benchmarks.ts.

This effectively undoes commit f1b2d13.
  • Loading branch information
KellyWalker committed Jul 16, 2024
1 parent 0bd63ec commit b142ee2
Show file tree
Hide file tree
Showing 3 changed files with 120 additions and 262 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"jest-environment-jsdom": "^29.6.2",
"moment": "^2.29.1",
"prettier": "^3.0.1",
"puppeteer": "^21.0.3",
"puppeteer": "^13.0.0",
"rimraf": "^5.0.1",
"rollup": "^3.28.0",
"rollup-plugin-commonjs": "^10.1.0",
Expand Down
2 changes: 1 addition & 1 deletion scripts/update_benchmarks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ type Optional<T, K extends keyof T> = Pick<Partial<T>, K> & Omit<T, K>;
});

async function fetchBenchmarks() {
const browser = await puppeteer.launch({ headless: 'new' });
const browser = await puppeteer.launch({ headless: true });
const page = await browser.newPage();

await page.goto(BENCHMARK_URL, { waitUntil: 'networkidle2' });
Expand Down
Loading

0 comments on commit b142ee2

Please sign in to comment.