🔫 Remove autoUpdate option #22
Conversation
|
Will release 1.0 after this |
| @@ -240,7 +239,7 @@ export default function cannonDebugger( | |||
|
|
|||
| let meshIndex = 0 | |||
|
|
|||
| for (const body of bodies) { | |||
| for (const body of world.bodies) { | |||
There was a problem hiding this comment.
Considering that you only use the world to access the bodies, it seems a bit overkill to bring the entire world into the debugger.
In use-cannon the world lives in a worker and we don't have direct access to it so it's quite difficult to have this as a requirement for using the debugger.
There was a problem hiding this comment.
I preferred matching the signature to the original CannonDebugRenderer.
We can just mock the world (like we're doing now) in use-cannon.
| @@ -30,13 +30,12 @@ export type DebugOptions = { | |||
| scale?: number | |||
| onInit?: (body: Body, mesh: Mesh, shape: Shape) => void | |||
| onUpdate?: (body: Body, mesh: Mesh, shape: Shape) => void | |||
| autoUpdate?: Boolean | |||
| } | |||
|
|
|||
| export default function cannonDebugger( | |||
There was a problem hiding this comment.
This does not match what is in the README:
export default class CannonDebugger {
constructor(scene: Scene, world: World, options: DebugOptions): void
update(): void
}There was a problem hiding this comment.
we're using this pattern because we don't want to expose the private variables, we can switch to a class when we can ship private class fields
Fixes #21
Having an internal raf loop has resulted in being problematic since the wireframe meshes were not in sync with the bodies. Also this behaviour appears to be confusing for cannon.js users.
Moreover, not even
use-cannonis actually using this feature.Makes sense to remove it completely.
I also went ahead and updated the signature to match the original CannonDebugRenderer.