Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Respawn Anchor #6646

Open
wants to merge 76 commits into
base: minor-next
Choose a base branch
from

Conversation

b1zeyofficial
Copy link

@b1zeyofficial b1zeyofficial commented Mar 6, 2025

Introduction

This PR implements Respawn Anchor
this is just a contribution to the community

Related issues & PRs

Changes

API changes

With the added BlockExplodeEvent and BlockPreExplodeEvent classes, the poor documentation needs to be changed and stuf

Behavioural changes

When RespawnAnchor explodes, Average TPS may drop by 19.24+-. Well, the respawn anchor itself has a "delay" in the Explosion

Backwards compatibility

Follow-up

Tests

https://www.youtube.com/watch?v=aI3ZItR3FY8

@b1zeyofficial b1zeyofficial requested a review from a team as a code owner March 6, 2025 09:45
@b1zeyofficial
Copy link
Author

I think someone will find a use for this, but for now it's closed.

@b1zeyofficial
Copy link
Author

It seems to have been fixed

@b1zeyofficial b1zeyofficial reopened this Mar 6, 2025
@b1zeyofficial
Copy link
Author

I checked php cs fixer locally but found no errors..

@b1zeyofficial
Copy link
Author

It seems like the generator starts and works.

ipad54
ipad54 previously approved these changes Mar 17, 2025
Copy link
Member

@ShockedPlot7560 ShockedPlot7560 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

@b1zeyofficial b1zeyofficial dismissed stale reviews from ShockedPlot7560 and ipad54 via 19a62ed March 25, 2025 06:37
@b1zeyofficial b1zeyofficial requested a review from ipad54 March 27, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Related to Minecraft gameplay experience Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants