Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates README to provide additional guidance on encrypted password process #143

Merged
merged 4 commits into from
Oct 1, 2019

Conversation

eemperor
Copy link
Member

Changes:

  • Added sample script to verify encrypted password Windows
  • Switch to single quotes in sample Linux bash command to handle special characters.

@eemperor eemperor requested a review from a team September 27, 2019 18:55
lorengordon
lorengordon previously approved these changes Sep 27, 2019
Copy link
Member

@ferricoxide ferricoxide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that single-quotes won't provide protection at the interactive-shell if you try to use ! as a special character in the password.

@eemperor
Copy link
Member Author

@ferricoxide Is it a particular shell? The one I'm using handles ! fine in the middle or beginning of password.

@eemperor
Copy link
Member Author

eemperor commented Oct 1, 2019

@plus3it/salt-formulas Pinning to older major version to workaround Salt Issue #54765 until a fix is released.

.travis.yml Outdated Show resolved Hide resolved
@eemperor eemperor merged commit 2edf64c into plus3it:master Oct 1, 2019
@eemperor eemperor deleted the readme branch October 1, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants