fix(widget): fix widget from central page #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orthagh
approved these changes
Oct 20, 2022
cedric-anne
reviewed
Oct 20, 2022
cedric-anne
reviewed
Oct 24, 2022
js/central.js.php
Outdated
Comment on lines
58
to
59
| container.append(text); | ||
| window.msnry = new Masonry('.masonry_grid'); |
There was a problem hiding this comment.
- Previous code was checking if response was empty before trying to append it. This can happens when there is no data to shown in the widget.
- Is this normal to redefine
window.msnry? - Is this notmal to remove call to
msnry.layout();?
There was a problem hiding this comment.
If i keep the old code the widgets are badly placed, I have two widgets on top of each other
With my method
All widgets are displayed and visible
I added the check on the ajax data received
cedric-anne
reviewed
Oct 25, 2022
cedric-anne
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix widget from central page
Before :
After :
