Add workaround for orca segmentation fault #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unset the NODE_OPTIONS environment variable before calling orca to avoid an orca segmentation fault
Example test failure:
```
======================================================================
ERROR: test_stream_single_points (plotly.tests.test_plot_ly.test_stream.test_stream.TestStreaming)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/circleci/project/plotly/tests/test_plot_ly/test_stream/test_stream.py", line 52, in test_stream_single_points
my_stream.write(Scatter(x=[1], y=[10]))
File "/home/circleci/project/plotly/plotly/plotly.py", line 704, in write
self._stream.write(jdata, reconnect_on=reconnect_on)
File "/home/circleci/project/plotly/plotly/chunked_requests/chunked_request.py", line 61, in write
msg=response.read()))
Exception: Server responded with status code: 502
and message: <html><body><h1>502 Bad Gateway</h1>
The server returned an invalid or incomplete response.
</body></html>
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in plotly/orca#124
This PR adds a line to unset the
NODE_OPTIONSenvironment variable before calling orca, thereby avoiding the segmentation fault.