Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Romanian locale #7351

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Update Romanian locale #7351

merged 2 commits into from
Feb 10, 2025

Conversation

ygorigor
Copy link
Contributor

Romanian Translation

I can't mention any speakers of this language because I don't know such people here on Github.

@gvwilson gvwilson added feature something new community community contribution P2 considered for next cycle labels Feb 3, 2025
@gvwilson
Copy link
Contributor

gvwilson commented Feb 3, 2025

Thanks @ygorigor - I'll try to find someone who can review this at our end and get it merged.

@gvwilson gvwilson self-assigned this Feb 3, 2025
Copy link

@Praemuntiacus Praemuntiacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Romanian translations look good to me, with the exception of this: 'kde:': 'evaluarea densității nucleare:' – the correct translation is either 'Estimarea densității nucleului' or 'Estimarea densității prin nucleu'.

@rudenco
Copy link

rudenco commented Feb 7, 2025

Translation looks good ~ 97 % given there are direct simple clear translations like : source --> sursă, lat --> latitudine, lower fence --> limita inferioară ... , I gave the translation task to a few LLM's ( XAI GROK, ChatGPT, Gemini ) + added a few personal insights ( like for example KDE - the suggestion being to leave it like it is for kernel density estimation ).

Attached is a PDF ("Plotly.js - translation RO.pdf") saved from EXCEL with current suggestion provided on the second column and the potential other suggestions on the columns that follow.

Meaning of colours in PDF :
green - good translation - no other recommendations
purple - good translation - some recommendations available - check columns that follow ( may remain the same )
orange - good translation - potential other recommendations my apply
red - the only one is for KDE - as also mentioned by Praemuntiacus - here I would leave it like it is.
Plotly.js - translation RO.pdf

@gvwilson
Copy link
Contributor

gvwilson commented Feb 7, 2025

@ygorigor can you please incorporate these suggestions into your pull request and then tag me here or email me (greg.wilson@plot.ly) and I'll merge? thank you, and thanks to @Praemuntiacus and @rudenco for input.

@ygorigor
Copy link
Contributor Author

ygorigor commented Feb 8, 2025

Ok @gvwilson. I'll do it ASAP. Thanks

@ygorigor
Copy link
Contributor Author

@gvwilson done

@gvwilson gvwilson merged commit 5363cf8 into plotly:master Feb 10, 2025
1 check failed
@gvwilson
Copy link
Contributor

thank you!

@ygorigor ygorigor deleted the patch-1 branch February 11, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants