Fix: Improvements to avoid distortions in sankey diagram links loops #7272
+158
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
reviewed
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Issue #7132
I tried to avoid distortion when the source and target of a link were moved. In the first place, I found a condition ("isSourceBeforeTarget") to use to know if a target block is before the source block or not, I used this condition to draw the path in two different ways. I used another condition ("isPathOverlapped") to improve the draw of the path when the two blocks are so close to having almost the whole path overlapped, this avoids, in part, some distortions and defines another way to draw the path in this particular condition. All the changes are done in the section of the path which is dedicated to drawing the arc both inner and outer