Do not break if mouse moves to x=0 when using rangeslider #6780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
reviewed
Nov 10, 2023
archmoj
reviewed
Nov 10, 2023
archmoj
reviewed
Nov 10, 2023
|
LGTM. |
alexcjohnson
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
💃 Great find and fix @david-bezero!
FWIW we haven’t used it yet since we were stuck in ES5 until recently, but we could do this with the nullish coalescing operator
|
I considered the nullish coalescing operator and searched through the code to see if you were using it, but found no occurrences so assumed it wasn't something that can be used in this codebase. Good to know it's now something you're happy to use though. |
Farkites
added a commit
that referenced
this pull request
Feb 2, 2024
birkskyum
pushed a commit
to birkskyum/plotly.js
that referenced
this pull request
Aug 20, 2024
seems to work for everything except regl traces put output name back to plotly.js update package-lock diff uninstall webpack uninstall webpack-cli uninstall node-polyfill-webpack-plugin uninstall karma-webpack drop webpack from devtools/test_dashboard/server.mjs remove webpack.config.js install buffer install assert rename devtools/regl_codegen/server from js to mjs remove unused purgeGeneratedCode function replace esbuild with webpack in devtools/regl_codegen/server rename tasks/bundle.js to tasks/bundle.mjs es6 imports in tasks/bundle.mjs bundle_wrapper.js > bundle_wrapper.mjs rename cibundle.js & partial_bundle.js to .mjs es6 import _bundle function replace webpack with esbuild in bundle_wrapper use esbuild to make bundles rewrite custom_bundle and extra_bundles in es6 js > mjs adjust export in partial_bundle.mjs do not provide sourcemap for now fix bundle_wrapper skip no-new-func test for now delete node12 tests set minimum node16 in package.json update package-lock for node 16 minimum install esbuild-plugin-browserify-adapter compress attributes add noCompress true to geo assets tasks/schema.js -> tasks/schema.mjs use es6 in tasks/schema.mjs tasks/util/plotly_node.js > tasks/util/plotly_node.mjs use es6 in tasks/util/plotly_node.mjs use es6 in tasks/test_plain_obj.js tasks/test_plain_obj.js > tasks/test_plain_obj.mjs tasks/test_requirejs.js > tasks/test_requirejs.mjs use es6 in tasks/test_requirejs.mjs use plotly_node.mjs in tasks/schema.mjs use es6 in tasks/test_mock.js tasks/test_mock.js > tasks/test_mock.mjs fix bundle to generate both minified & unmininified fix bundle_wrapper to not clear plugins install esbuild-plugin-babel use esbuild-plugin-babel in esbuild-config fx-config no plugins to bundle geo assests improve name of _bundle option fix empty plugins fix esbuild config setup adjust esbuild config skip requirejs and amdefine tests for now drop babel step fix disabling attribute meta compression fix __dirname in test_mock install karma-esbuild use esbuild with karma and jasmine drop babel drop amdefine test simplify minified_bundle case clear IE option in karma config fx reduce parallelism for jasmine tests use "r" type rather than "d" for axes in insiderange calculations fixes insiderange for category axes, also presumably for log axes draft log baseline before PR baseline after PR Add x boundaries for ticksarray Fix lint errors Replace baseline Add draftlog Added static gradient fills for scatter traces. Adds a new attribute `fillgradient` to `scatter` traces which allows the user to specify a gradient as a colorscale and an orientation in which it will be applied. `fillgradient` also has optional start and stop attributes which can be used to define absolute start and stop points in plot coordiantes. This allows to equip different traces with exactly matching fill gradients. Omitting start and stop will apply the gradient between the extrema of the fill polygon (along the fill direction). When a legend is displayed, multiple passes are made through the `Drawing.setFillStyle` function, for the legend previews and the actual plot, during which the axes are re-scaled. This leads to errors with gradients not computing start and stop coordinates correctly. To work around this, `setFillStyle` was modified to allow distinguishing between legend and plot passes. added generated plot-schema for scatter gradient fills. Changes for fillgradients based on first review - removed assert - renamed new mocks and baselines - used local variable instead of direct reference to trace property - added trailing newlines to new mock .json files Changed scatter attribute fillgradient.orientation to fillgradient.type for greater consistency with marker.gradient.type makeFillcolorAttr function with hasFillgradient option move makeFillcolorAttr to a file adjust fillcolor function and use it in traces Removing traceIn.fillgradient check in fillColorDefaults draftlog file for scatter fill gradients add moduleHasFillgradient option to fillColorDefaults Add jasmine test for bugfix plotly#6780 Fix syntax on new select test Check selectedpoints in _fullData Revert _fullData to access selectedpoints in test Change drag coordinates Change drag coordinates for the second test Change drag coordinates for the second test Change drag coordinates to max for the second test Change drag coordinates for the second test Change order of drags Reduce height of test plot Add mocks for testing Fix calcLabelBBox to return sensible value when no label Remove mocks to pass tests Revert "Remove mocks to pass tests" This reverts commit 5503c70. baselines - before baselines - after add draftlog adjustments skip petrophysics in test mock for now rename new mocks new baselines generated on the CI coerce textposition if textinfo is "none" add draft log fix linting changelog and readme for v2.30.0 2.30.0 bring back amdefine test drop babel deps install esbuild-plugin-umd-wrapper add umd wrapper revise adjusting plugins fix bundle wrapper fix second bundles revise bundles fix centering multi-line headers in treemap add test draft log add test showing bug use background color for contrast text on cells with missing data update baseline display hidden text on heatmap_xyz-gaps-on-sides avoid formatting missing data in texttemplate draft log bump color-parse v2 fixing 6685 add test draft log rename new mocks new baselines generated by CI npm audit fix - bump follow-redirects changelog and readme for v2.30.1 2.30.1 add cone size test new baselines generated by CI having new list orders Update config.yml Update config.yml Update config.yml Update config.yml Update config.yml provide dev-deps to bundle stackgl index.js and pin down versions add test-bundle-stackgl regenrate stackgl bundle revise stackgl type from umd to commonjs-module draft log Fix deprecated dependency notation Minor change to replaces a semver v1 notation (with leading `v`) with semver v2. PS: The npm semver package most likely will deprecate semver v1 support in next major. Add shapes.layer value "belowtraces" for drawing shapes in between gridlines and traces Add draftlog Add baseline image for shapes_layer_below_traces.json Make sure new test images run last Update splom_test's innerSubplotNodeCnt and index of xaxislayer-above Rename "belowtraces" to "between" Add "between to newshape.layer as well. Make line length of description shorter. Fix descriptions for shapes.layer and newshape.layer Test more cases in shapes_layer_below_traces mock - added axis y2 to test interaction between axes - added shape label - moved dashdot line to see more of its interaction with the gridlines - removed transparency for easier visual checking Updated baseline image for changed shapes_layer_below_traces mock shapes_layer_below_traces mock: Make y and y2 gridlines visually distinct updated baseline image after changing shapes_layer_below_traces mock Update draftlogs/6927_add.md add vector sizemode option to cone update schema test add new test test sizeref with vector sizemode link to changes in gl-cone3d update stackgl-bundle new mock rename option to raw bump gl-cone3d 1.6.0 and rebuild stackgl index change color countLabel to bandColorCount change parcats_hoveron_color to include count in hoverinfo draftlogs 6944 draftlogs 6944 Update draftlogs/6944_change.md hover on subplots when they anchored to same x or y add jasmine tests test unified hover including points in other plots draft log refactor refactor handle splom splom test do not loop in newly added items rename attribute revise attribute def do not sort items when hovering over multiple subplots rename to hoversubplots revise attributes add single option add test fix case of splom with multiple points at same (x|y) position simplify splom hover mention the PR in draftlogs zindex first pass. scatter and bar traces only Ensure zindex is compared by trace Add zindex basic baseline update plot-schema diff Add zindex to image Add zindex to all cartesian traces Update schema Fix scattergl zindex Add baseline /zindex-scatter-image.png Restore dist Remove scattergl zindex Remove coerce zindex from scattergl Remove zindex from funnelarea Remove zindex from funnelarea Add zindex for ohlc Add mocks for zindex Add baselines Fix zindex_violin_box mock Add draftlog Define zindex in scatter attributes Use Lib.sorterAsc for zindices Handle zindex undefined in sort Update draftlog Update description Update zindex-scatter-image mock Add mocks for zindex in histogram, heatmap, and contour traces Add zindex to histogram traces Fix zindex routing in attributes Update zindex description Add baselines for zindex image, contour, heatmap, and histogram mocks Change zindex editType to 'plot' Add zindex to funnel_axis_with_other_traces mock Add new baseline for funnel_axis_with_other_traces Update plot-schema Fix funnel_axis_with_other_traces baseline Remove zindex_histogram mock and baseline Reduce width and height of zindex mocks Update zindex baselines Add Jasmine tests for zindex Add jasmine test for clearing and adding zindex traces Add select tests for zindex traces Change naming of layers with zindex Remove focus in tests Add zindex tests for bar traces Fix index of layer names for negative zindex Add overlaying bar traces to zindex_basic mock Extend zindex test to waterfall and funnel traces rename zindex to zorder rename new mocks update baselines generated with new order on CircleCI update mapbox-gl version in package-lock npm audit fix take into account zorder when hovering add jasmine test correct click and select test with zorder adjust draftlog update readme and changelog for v2.31.0 2.31.0 npm audit fix fix default trace orders when zorder is present for some add test draftlog fix (x|y) spike position and ensure main subplot hover points are sorted first jasmine test draftlog avoid duplicates in splom hover draftlog comment readme and changelog for v2.31.1 2.31.1 use raw sizemode in gl3d_cone-wind revisit colors Apply autotickangles also on axes with tickson="boundaries" and axes with showdividers=true Add draftlog for PR 6967 Update baseline image tickson_boundaries.png, now honors autotickangles Make test "should rotate labels to avoid overlap" more lenient for float and update expected angle test "should rotate labels to avoid overlap": Fix toBeCloseTo call and deprecation warnings. test "should rotate labels to avoid overlap": Fix next failing test Update test "drag to wide-range -> rotate labels" for autotickangles Update draftlogs/6967_fix.md Fix inconsistent axis title standoff when title is one text line vs. multiple lines. Previously, the standoff was calculated in the same way for all axis sides, but since the renderer draws from top left to bottom right, the code must be different for top/left axes titles and bottom/right axes titles: For top/left axes all lines after the first of a multiline title require extra space before the ticklabels, whereas for bottom/right axes, the drawing baseline needs to be shifted 1 line after the ticklabels to prevent overlap. Add draftlog for PR 6970 For top/left axes side: Account for descender portion (the tail of p, y, g etc.) of the first line of the title as well. Fix axis-title-standoff.json yaxis title text Claimed to have standoff 8 although it has standoff 0. update baselines and new mock (cherry picked from commit 1e69c85) Better draftlog description for PR 6970 Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com> add weight, style, stretch and variant to font bar carpet contour heatmap indicator parcats parcoords pie sankey scatter scattergl sunburst table scatter3d scattermapbox annotations colorbar legend titles hover effects plots cartesian polar ternary gl3d gl-text fix for handling styles new schema add and adjust jasmine tests style waterfall_profit-loss_2018vs2019_textinfo_base style heatmap_xyz-gaps-on-sides style gl2d_text_chart_arrays style text_chart_arrays style text_on_shapes_basic style bar_annotation_max_range_eq_category style texttemplate_scatter style texttemplate fix typo in src/components/fx/hover.js add extras option to integer in lib.coerce declare weight as integer update schema adjust bar fix src/traces/sunburst/fx.js use Lib.coerceFont in indicator style test/image/mocks/indicator_attrs style indicator_bullet style gl2d_parcoords_constraints style parcats_basic_freeform style scattercarpet-text use layout.font in carpet/defaults.js style funnelarea_with_other_traces style treemap_fonts_nocolor style sankey_energy style trace_metatext style parcats fix indicator guage.axis default font Revert "scattermapbox" This reverts commit 2c39a8e. no support in scattermapbox add font style options to gl-axes3d update trace_metatext handle font styles in gl-scatter3d style gl3d_scatter3d-blank-text handle styles in gl-plot2d and text-cache style gl2d_heatmapgl revise font.stretch options correct oblique options drop oblique angle options that are quite confusing remove stretch from src remove stretch from test update schema diff remove stretch in gl-axes3d gl-plot2d and text-cache adjust toimage_test add descriptions fix hover use layout.font styling defaults in hover make arrayOk styling attributes revise variant options image test for font-variants keep working options in test revise new attributes new tests update link to gl-scatter3d handle array font family, weight, style & variant in gl-scatter3d skip font-variant-bar in mock test update package-lock.json test font options in scattergl and scatter3d revise font options limit variant options for scattergl and scatter3d - arrayOk scatter3d family supported now add bold and italic to scattermapbox no integer weight do not include font styling options in svg when set to normal refactor fix mapbox font correct coerce function and remove unused code revise opt name remove comments - these are arrayOk & handled now by gl-scatter3d revise mock fix cluster mapbox font inherit family, weight & style draft log bump gl-text bump stackgl modules npm audit fix changelog and readme for v2.32.0 2.32.0 reduce drawing font args - delete unused method rename new mocks baselines generated on ci with new order adjust parallelism of make-baselines-virtual-webgl to reduce falkiness bump plotly/d3 v3.8.2 - rename unicode var names draft log add text-shadow, text-decoration-line & text-transform in drawing.font declare new text font styling attributes implementation adjust toSVG to skip none text style values set auto shadow for sankey, parcats and parcoords that has text-shadow before update sankey, parcats & parcoords baselines - revise contrast src fix shadow attr def update schema adjust jasmine tests test axes_custom-ticks_log-date test axes_labels test bar_annotation_max_range_eq_category test bar_attrs_group_norm test bar-colorscale-colorbar test bar_gantt-chart test benchmarks test canada_geo_projections test cliponaxis_false-dates-log test container-legend test contour_constraints_equal_boundary_minmax test font-variant-bar test funnel_axis_textangle_outside test funnel_horizontal_group_basic test geo_africa-insets test geo_canadian-cities test geo_country-names-text-chart test geo_text_chart_arrays test geo_text_chart_arrays custom title shadow test heatmap_brick_padding test heatmap-text-color-on-missing-data test indicator_attrs test indicator_scatter test insiderange test pie_legend_line_color_array test polar_bar-overlay test sankey_messy test text_on_shapes_basic test texttemplate test texttemplate_scatter test ticklabelposition-5 test treemap_multi-line_headers introduce overrideDflt option for coerceFont refactor src/components/fx/hover.js fix colorbar.title.font default capitalize none > normal lowercase > lower, uppercase > upper replace case options with object striding > decorline Revert "no integer weight" This reverts commit f4d4f4c. also drop font-weight 400 when exporting to SVG test scatter font weight test bar font weight use numeric font-weight in mocks skip validating font-weight-bar mock draft log numeric text weight in gl3d link to include extra valid font-weight options in css-font and gl-text test numeric font-weight values in scattergl pipeline Revert "link to include extra valid font-weight options in css-font and gl-text" This reverts commit abb3fc8. fall back for unsupported font-weight values scattergl numeric font-weight render using bold/normal fallback correct mock name improve scattergl test test numeric weight in gl2d axis text convert typed array spec in integer, number, color, etc handle typed arrays in scatter3d handle typed arrays in gl-axes3d handle numeric font weight in mapbox supported fonts fix toSVG using weight: 400 improve mapbox text weight and italic handling fix support of Open Sans Extrabold fonts test metropolis fonts on mapbox test italic Metropolis fonts add weight test for open sans fonts - duplicate simple open-sans baseline add weight test for metropolis fonts - duplicate simple metropolis baseline Revert "test italic Metropolis fonts" This reverts commit 190aef1. test numeric weights on axes 3d bump gl-axes3d and gl-scatter3d refactor src/traces/scattergl/convert.js improve font family checks add comment Bring back one new mock tested in 6990 - Revert "Revert "test italic Metropolis fonts"" This reverts commit 59779f3. rename newly added mocks and baselines regenrated baselines due to new order bug on the CI rename keys correct schema capitalize > textcase textcase: word > headline textcase: headline > caps - Capitalizing Every Word Is NOT headline case use new options in trace_metatext mock test new options use Drawing.font to style titles caps > word caps decorline > lineposition clear none text font styles instead of setting to none fix getFullTransformMatrix in shadow DOM Add draft log fix getFullTransformMatrix in shadow DOM fix drag on legend scrollbar Add draft log Improve numerical stability of projection When the position vector has large values that are cancelled out by large values in the model matrix, it is more numerically stable to first multiply the position by the model matrix instead of multiplying the matrices together first. Use forks of the gl-vis libraries that use the problematic pattern. Update 3D baseline images Add draftlog Add one testcase to flaky virtual-webgl tests list Remove overrides in stackgl_modules package.json Update gl-axes3d Update gl-vis dependencies to new upstream versions Update draftlogs/6998_fix.md Improve precision of surface3d worldPosition calculation When the objectOffset is very large compared to the values in the localCoordinate, adding it to the localCoordinate loses precision in the localCoordinate. As the addition of the objectOffset was immediately undone by application of the model matrix, it is better to combine the model matrix and the translation by the objectOffset into one matrix and apply it directly to the localCoordinate. Update surface plot baseline images Add draftlog Update gl-surface3d dependency Add test for small timerange on surface plot Update draftlog Fix syntax of test with small timerange Add baseline for small timerange on surface plot fix isosurface _vMax calculation when isomax is null log for PR 7002
birkskyum
pushed a commit
to birkskyum/plotly.js
that referenced
this pull request
Aug 20, 2024
seems to work for everything except regl traces put output name back to plotly.js update package-lock diff uninstall webpack uninstall webpack-cli uninstall node-polyfill-webpack-plugin uninstall karma-webpack drop webpack from devtools/test_dashboard/server.mjs remove webpack.config.js install buffer install assert rename devtools/regl_codegen/server from js to mjs remove unused purgeGeneratedCode function replace esbuild with webpack in devtools/regl_codegen/server rename tasks/bundle.js to tasks/bundle.mjs es6 imports in tasks/bundle.mjs bundle_wrapper.js > bundle_wrapper.mjs rename cibundle.js & partial_bundle.js to .mjs es6 import _bundle function replace webpack with esbuild in bundle_wrapper use esbuild to make bundles rewrite custom_bundle and extra_bundles in es6 js > mjs adjust export in partial_bundle.mjs do not provide sourcemap for now fix bundle_wrapper skip no-new-func test for now delete node12 tests set minimum node16 in package.json update package-lock for node 16 minimum install esbuild-plugin-browserify-adapter compress attributes add noCompress true to geo assets tasks/schema.js -> tasks/schema.mjs use es6 in tasks/schema.mjs tasks/util/plotly_node.js > tasks/util/plotly_node.mjs use es6 in tasks/util/plotly_node.mjs use es6 in tasks/test_plain_obj.js tasks/test_plain_obj.js > tasks/test_plain_obj.mjs tasks/test_requirejs.js > tasks/test_requirejs.mjs use es6 in tasks/test_requirejs.mjs use plotly_node.mjs in tasks/schema.mjs use es6 in tasks/test_mock.js tasks/test_mock.js > tasks/test_mock.mjs fix bundle to generate both minified & unmininified fix bundle_wrapper to not clear plugins install esbuild-plugin-babel use esbuild-plugin-babel in esbuild-config fx-config no plugins to bundle geo assests improve name of _bundle option fix empty plugins fix esbuild config setup adjust esbuild config skip requirejs and amdefine tests for now drop babel step fix disabling attribute meta compression fix __dirname in test_mock install karma-esbuild use esbuild with karma and jasmine drop babel drop amdefine test simplify minified_bundle case clear IE option in karma config fx reduce parallelism for jasmine tests use "r" type rather than "d" for axes in insiderange calculations fixes insiderange for category axes, also presumably for log axes draft log baseline before PR baseline after PR Add x boundaries for ticksarray Fix lint errors Replace baseline Add draftlog Added static gradient fills for scatter traces. Adds a new attribute `fillgradient` to `scatter` traces which allows the user to specify a gradient as a colorscale and an orientation in which it will be applied. `fillgradient` also has optional start and stop attributes which can be used to define absolute start and stop points in plot coordiantes. This allows to equip different traces with exactly matching fill gradients. Omitting start and stop will apply the gradient between the extrema of the fill polygon (along the fill direction). When a legend is displayed, multiple passes are made through the `Drawing.setFillStyle` function, for the legend previews and the actual plot, during which the axes are re-scaled. This leads to errors with gradients not computing start and stop coordinates correctly. To work around this, `setFillStyle` was modified to allow distinguishing between legend and plot passes. added generated plot-schema for scatter gradient fills. Changes for fillgradients based on first review - removed assert - renamed new mocks and baselines - used local variable instead of direct reference to trace property - added trailing newlines to new mock .json files Changed scatter attribute fillgradient.orientation to fillgradient.type for greater consistency with marker.gradient.type makeFillcolorAttr function with hasFillgradient option move makeFillcolorAttr to a file adjust fillcolor function and use it in traces Removing traceIn.fillgradient check in fillColorDefaults draftlog file for scatter fill gradients add moduleHasFillgradient option to fillColorDefaults Add jasmine test for bugfix plotly#6780 Fix syntax on new select test Check selectedpoints in _fullData Revert _fullData to access selectedpoints in test Change drag coordinates Change drag coordinates for the second test Change drag coordinates for the second test Change drag coordinates to max for the second test Change drag coordinates for the second test Change order of drags Reduce height of test plot Add mocks for testing Fix calcLabelBBox to return sensible value when no label Remove mocks to pass tests Revert "Remove mocks to pass tests" This reverts commit 5503c70. baselines - before baselines - after add draftlog adjustments skip petrophysics in test mock for now rename new mocks new baselines generated on the CI coerce textposition if textinfo is "none" add draft log fix linting changelog and readme for v2.30.0 2.30.0 bring back amdefine test drop babel deps install esbuild-plugin-umd-wrapper add umd wrapper revise adjusting plugins fix bundle wrapper fix second bundles revise bundles fix centering multi-line headers in treemap add test draft log add test showing bug use background color for contrast text on cells with missing data update baseline display hidden text on heatmap_xyz-gaps-on-sides avoid formatting missing data in texttemplate draft log bump color-parse v2 fixing 6685 add test draft log rename new mocks new baselines generated by CI npm audit fix - bump follow-redirects changelog and readme for v2.30.1 2.30.1 add cone size test new baselines generated by CI having new list orders Update config.yml Update config.yml Update config.yml Update config.yml Update config.yml provide dev-deps to bundle stackgl index.js and pin down versions add test-bundle-stackgl regenrate stackgl bundle revise stackgl type from umd to commonjs-module draft log Fix deprecated dependency notation Minor change to replaces a semver v1 notation (with leading `v`) with semver v2. PS: The npm semver package most likely will deprecate semver v1 support in next major. Add shapes.layer value "belowtraces" for drawing shapes in between gridlines and traces Add draftlog Add baseline image for shapes_layer_below_traces.json Make sure new test images run last Update splom_test's innerSubplotNodeCnt and index of xaxislayer-above Rename "belowtraces" to "between" Add "between to newshape.layer as well. Make line length of description shorter. Fix descriptions for shapes.layer and newshape.layer Test more cases in shapes_layer_below_traces mock - added axis y2 to test interaction between axes - added shape label - moved dashdot line to see more of its interaction with the gridlines - removed transparency for easier visual checking Updated baseline image for changed shapes_layer_below_traces mock shapes_layer_below_traces mock: Make y and y2 gridlines visually distinct updated baseline image after changing shapes_layer_below_traces mock Update draftlogs/6927_add.md add vector sizemode option to cone update schema test add new test test sizeref with vector sizemode link to changes in gl-cone3d update stackgl-bundle new mock rename option to raw bump gl-cone3d 1.6.0 and rebuild stackgl index change color countLabel to bandColorCount change parcats_hoveron_color to include count in hoverinfo draftlogs 6944 draftlogs 6944 Update draftlogs/6944_change.md hover on subplots when they anchored to same x or y add jasmine tests test unified hover including points in other plots draft log refactor refactor handle splom splom test do not loop in newly added items rename attribute revise attribute def do not sort items when hovering over multiple subplots rename to hoversubplots revise attributes add single option add test fix case of splom with multiple points at same (x|y) position simplify splom hover mention the PR in draftlogs zindex first pass. scatter and bar traces only Ensure zindex is compared by trace Add zindex basic baseline update plot-schema diff Add zindex to image Add zindex to all cartesian traces Update schema Fix scattergl zindex Add baseline /zindex-scatter-image.png Restore dist Remove scattergl zindex Remove coerce zindex from scattergl Remove zindex from funnelarea Remove zindex from funnelarea Add zindex for ohlc Add mocks for zindex Add baselines Fix zindex_violin_box mock Add draftlog Define zindex in scatter attributes Use Lib.sorterAsc for zindices Handle zindex undefined in sort Update draftlog Update description Update zindex-scatter-image mock Add mocks for zindex in histogram, heatmap, and contour traces Add zindex to histogram traces Fix zindex routing in attributes Update zindex description Add baselines for zindex image, contour, heatmap, and histogram mocks Change zindex editType to 'plot' Add zindex to funnel_axis_with_other_traces mock Add new baseline for funnel_axis_with_other_traces Update plot-schema Fix funnel_axis_with_other_traces baseline Remove zindex_histogram mock and baseline Reduce width and height of zindex mocks Update zindex baselines Add Jasmine tests for zindex Add jasmine test for clearing and adding zindex traces Add select tests for zindex traces Change naming of layers with zindex Remove focus in tests Add zindex tests for bar traces Fix index of layer names for negative zindex Add overlaying bar traces to zindex_basic mock Extend zindex test to waterfall and funnel traces rename zindex to zorder rename new mocks update baselines generated with new order on CircleCI update mapbox-gl version in package-lock npm audit fix take into account zorder when hovering add jasmine test correct click and select test with zorder adjust draftlog update readme and changelog for v2.31.0 2.31.0 npm audit fix fix default trace orders when zorder is present for some add test draftlog fix (x|y) spike position and ensure main subplot hover points are sorted first jasmine test draftlog avoid duplicates in splom hover draftlog comment readme and changelog for v2.31.1 2.31.1 use raw sizemode in gl3d_cone-wind revisit colors Apply autotickangles also on axes with tickson="boundaries" and axes with showdividers=true Add draftlog for PR 6967 Update baseline image tickson_boundaries.png, now honors autotickangles Make test "should rotate labels to avoid overlap" more lenient for float and update expected angle test "should rotate labels to avoid overlap": Fix toBeCloseTo call and deprecation warnings. test "should rotate labels to avoid overlap": Fix next failing test Update test "drag to wide-range -> rotate labels" for autotickangles Update draftlogs/6967_fix.md Fix inconsistent axis title standoff when title is one text line vs. multiple lines. Previously, the standoff was calculated in the same way for all axis sides, but since the renderer draws from top left to bottom right, the code must be different for top/left axes titles and bottom/right axes titles: For top/left axes all lines after the first of a multiline title require extra space before the ticklabels, whereas for bottom/right axes, the drawing baseline needs to be shifted 1 line after the ticklabels to prevent overlap. Add draftlog for PR 6970 For top/left axes side: Account for descender portion (the tail of p, y, g etc.) of the first line of the title as well. Fix axis-title-standoff.json yaxis title text Claimed to have standoff 8 although it has standoff 0. update baselines and new mock (cherry picked from commit 1e69c85) Better draftlog description for PR 6970 Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com> add weight, style, stretch and variant to font bar carpet contour heatmap indicator parcats parcoords pie sankey scatter scattergl sunburst table scatter3d scattermapbox annotations colorbar legend titles hover effects plots cartesian polar ternary gl3d gl-text fix for handling styles new schema add and adjust jasmine tests style waterfall_profit-loss_2018vs2019_textinfo_base style heatmap_xyz-gaps-on-sides style gl2d_text_chart_arrays style text_chart_arrays style text_on_shapes_basic style bar_annotation_max_range_eq_category style texttemplate_scatter style texttemplate fix typo in src/components/fx/hover.js add extras option to integer in lib.coerce declare weight as integer update schema adjust bar fix src/traces/sunburst/fx.js use Lib.coerceFont in indicator style test/image/mocks/indicator_attrs style indicator_bullet style gl2d_parcoords_constraints style parcats_basic_freeform style scattercarpet-text use layout.font in carpet/defaults.js style funnelarea_with_other_traces style treemap_fonts_nocolor style sankey_energy style trace_metatext style parcats fix indicator guage.axis default font Revert "scattermapbox" This reverts commit 2c39a8e. no support in scattermapbox add font style options to gl-axes3d update trace_metatext handle font styles in gl-scatter3d style gl3d_scatter3d-blank-text handle styles in gl-plot2d and text-cache style gl2d_heatmapgl revise font.stretch options correct oblique options drop oblique angle options that are quite confusing remove stretch from src remove stretch from test update schema diff remove stretch in gl-axes3d gl-plot2d and text-cache adjust toimage_test add descriptions fix hover use layout.font styling defaults in hover make arrayOk styling attributes revise variant options image test for font-variants keep working options in test revise new attributes new tests update link to gl-scatter3d handle array font family, weight, style & variant in gl-scatter3d skip font-variant-bar in mock test update package-lock.json test font options in scattergl and scatter3d revise font options limit variant options for scattergl and scatter3d - arrayOk scatter3d family supported now add bold and italic to scattermapbox no integer weight do not include font styling options in svg when set to normal refactor fix mapbox font correct coerce function and remove unused code revise opt name remove comments - these are arrayOk & handled now by gl-scatter3d revise mock fix cluster mapbox font inherit family, weight & style draft log bump gl-text bump stackgl modules npm audit fix changelog and readme for v2.32.0 2.32.0 reduce drawing font args - delete unused method rename new mocks baselines generated on ci with new order adjust parallelism of make-baselines-virtual-webgl to reduce falkiness bump plotly/d3 v3.8.2 - rename unicode var names draft log add text-shadow, text-decoration-line & text-transform in drawing.font declare new text font styling attributes implementation adjust toSVG to skip none text style values set auto shadow for sankey, parcats and parcoords that has text-shadow before update sankey, parcats & parcoords baselines - revise contrast src fix shadow attr def update schema adjust jasmine tests test axes_custom-ticks_log-date test axes_labels test bar_annotation_max_range_eq_category test bar_attrs_group_norm test bar-colorscale-colorbar test bar_gantt-chart test benchmarks test canada_geo_projections test cliponaxis_false-dates-log test container-legend test contour_constraints_equal_boundary_minmax test font-variant-bar test funnel_axis_textangle_outside test funnel_horizontal_group_basic test geo_africa-insets test geo_canadian-cities test geo_country-names-text-chart test geo_text_chart_arrays test geo_text_chart_arrays custom title shadow test heatmap_brick_padding test heatmap-text-color-on-missing-data test indicator_attrs test indicator_scatter test insiderange test pie_legend_line_color_array test polar_bar-overlay test sankey_messy test text_on_shapes_basic test texttemplate test texttemplate_scatter test ticklabelposition-5 test treemap_multi-line_headers introduce overrideDflt option for coerceFont refactor src/components/fx/hover.js fix colorbar.title.font default capitalize none > normal lowercase > lower, uppercase > upper replace case options with object striding > decorline Revert "no integer weight" This reverts commit f4d4f4c. also drop font-weight 400 when exporting to SVG test scatter font weight test bar font weight use numeric font-weight in mocks skip validating font-weight-bar mock draft log numeric text weight in gl3d link to include extra valid font-weight options in css-font and gl-text test numeric font-weight values in scattergl pipeline Revert "link to include extra valid font-weight options in css-font and gl-text" This reverts commit abb3fc8. fall back for unsupported font-weight values scattergl numeric font-weight render using bold/normal fallback correct mock name improve scattergl test test numeric weight in gl2d axis text convert typed array spec in integer, number, color, etc handle typed arrays in scatter3d handle typed arrays in gl-axes3d handle numeric font weight in mapbox supported fonts fix toSVG using weight: 400 improve mapbox text weight and italic handling fix support of Open Sans Extrabold fonts test metropolis fonts on mapbox test italic Metropolis fonts add weight test for open sans fonts - duplicate simple open-sans baseline add weight test for metropolis fonts - duplicate simple metropolis baseline Revert "test italic Metropolis fonts" This reverts commit 190aef1. test numeric weights on axes 3d bump gl-axes3d and gl-scatter3d refactor src/traces/scattergl/convert.js improve font family checks add comment Bring back one new mock tested in 6990 - Revert "Revert "test italic Metropolis fonts"" This reverts commit 59779f3. rename newly added mocks and baselines regenrated baselines due to new order bug on the CI rename keys correct schema capitalize > textcase textcase: word > headline textcase: headline > caps - Capitalizing Every Word Is NOT headline case use new options in trace_metatext mock test new options use Drawing.font to style titles caps > word caps decorline > lineposition clear none text font styles instead of setting to none fix getFullTransformMatrix in shadow DOM Add draft log fix getFullTransformMatrix in shadow DOM fix drag on legend scrollbar Add draft log Improve numerical stability of projection When the position vector has large values that are cancelled out by large values in the model matrix, it is more numerically stable to first multiply the position by the model matrix instead of multiplying the matrices together first. Use forks of the gl-vis libraries that use the problematic pattern. Update 3D baseline images Add draftlog Add one testcase to flaky virtual-webgl tests list Remove overrides in stackgl_modules package.json Update gl-axes3d Update gl-vis dependencies to new upstream versions Update draftlogs/6998_fix.md Improve precision of surface3d worldPosition calculation When the objectOffset is very large compared to the values in the localCoordinate, adding it to the localCoordinate loses precision in the localCoordinate. As the addition of the objectOffset was immediately undone by application of the model matrix, it is better to combine the model matrix and the translation by the objectOffset into one matrix and apply it directly to the localCoordinate. Update surface plot baseline images Add draftlog Update gl-surface3d dependency Add test for small timerange on surface plot Update draftlog Fix syntax of test with small timerange Add baseline for small timerange on surface plot fix isosurface _vMax calculation when isomax is null log for PR 7002 cleanup dist
birkskyum
pushed a commit
to birkskyum/plotly.js
that referenced
this pull request
Aug 20, 2024
seems to work for everything except regl traces put output name back to plotly.js update package-lock diff uninstall webpack uninstall webpack-cli uninstall node-polyfill-webpack-plugin uninstall karma-webpack drop webpack from devtools/test_dashboard/server.mjs remove webpack.config.js install buffer install assert rename devtools/regl_codegen/server from js to mjs remove unused purgeGeneratedCode function replace esbuild with webpack in devtools/regl_codegen/server rename tasks/bundle.js to tasks/bundle.mjs es6 imports in tasks/bundle.mjs bundle_wrapper.js > bundle_wrapper.mjs rename cibundle.js & partial_bundle.js to .mjs es6 import _bundle function replace webpack with esbuild in bundle_wrapper use esbuild to make bundles rewrite custom_bundle and extra_bundles in es6 js > mjs adjust export in partial_bundle.mjs do not provide sourcemap for now fix bundle_wrapper skip no-new-func test for now delete node12 tests set minimum node16 in package.json update package-lock for node 16 minimum install esbuild-plugin-browserify-adapter compress attributes add noCompress true to geo assets tasks/schema.js -> tasks/schema.mjs use es6 in tasks/schema.mjs tasks/util/plotly_node.js > tasks/util/plotly_node.mjs use es6 in tasks/util/plotly_node.mjs use es6 in tasks/test_plain_obj.js tasks/test_plain_obj.js > tasks/test_plain_obj.mjs tasks/test_requirejs.js > tasks/test_requirejs.mjs use es6 in tasks/test_requirejs.mjs use plotly_node.mjs in tasks/schema.mjs use es6 in tasks/test_mock.js tasks/test_mock.js > tasks/test_mock.mjs fix bundle to generate both minified & unmininified fix bundle_wrapper to not clear plugins install esbuild-plugin-babel use esbuild-plugin-babel in esbuild-config fx-config no plugins to bundle geo assests improve name of _bundle option fix empty plugins fix esbuild config setup adjust esbuild config skip requirejs and amdefine tests for now drop babel step fix disabling attribute meta compression fix __dirname in test_mock install karma-esbuild use esbuild with karma and jasmine drop babel drop amdefine test simplify minified_bundle case clear IE option in karma config fx reduce parallelism for jasmine tests use "r" type rather than "d" for axes in insiderange calculations fixes insiderange for category axes, also presumably for log axes draft log baseline before PR baseline after PR Add x boundaries for ticksarray Fix lint errors Replace baseline Add draftlog Added static gradient fills for scatter traces. Adds a new attribute `fillgradient` to `scatter` traces which allows the user to specify a gradient as a colorscale and an orientation in which it will be applied. `fillgradient` also has optional start and stop attributes which can be used to define absolute start and stop points in plot coordiantes. This allows to equip different traces with exactly matching fill gradients. Omitting start and stop will apply the gradient between the extrema of the fill polygon (along the fill direction). When a legend is displayed, multiple passes are made through the `Drawing.setFillStyle` function, for the legend previews and the actual plot, during which the axes are re-scaled. This leads to errors with gradients not computing start and stop coordinates correctly. To work around this, `setFillStyle` was modified to allow distinguishing between legend and plot passes. added generated plot-schema for scatter gradient fills. Changes for fillgradients based on first review - removed assert - renamed new mocks and baselines - used local variable instead of direct reference to trace property - added trailing newlines to new mock .json files Changed scatter attribute fillgradient.orientation to fillgradient.type for greater consistency with marker.gradient.type makeFillcolorAttr function with hasFillgradient option move makeFillcolorAttr to a file adjust fillcolor function and use it in traces Removing traceIn.fillgradient check in fillColorDefaults draftlog file for scatter fill gradients add moduleHasFillgradient option to fillColorDefaults Add jasmine test for bugfix plotly#6780 Fix syntax on new select test Check selectedpoints in _fullData Revert _fullData to access selectedpoints in test Change drag coordinates Change drag coordinates for the second test Change drag coordinates for the second test Change drag coordinates to max for the second test Change drag coordinates for the second test Change order of drags Reduce height of test plot Add mocks for testing Fix calcLabelBBox to return sensible value when no label Remove mocks to pass tests Revert "Remove mocks to pass tests" This reverts commit 5503c70. baselines - before baselines - after add draftlog adjustments skip petrophysics in test mock for now rename new mocks new baselines generated on the CI coerce textposition if textinfo is "none" add draft log fix linting changelog and readme for v2.30.0 2.30.0 bring back amdefine test drop babel deps install esbuild-plugin-umd-wrapper add umd wrapper revise adjusting plugins fix bundle wrapper fix second bundles revise bundles fix centering multi-line headers in treemap add test draft log add test showing bug use background color for contrast text on cells with missing data update baseline display hidden text on heatmap_xyz-gaps-on-sides avoid formatting missing data in texttemplate draft log bump color-parse v2 fixing 6685 add test draft log rename new mocks new baselines generated by CI npm audit fix - bump follow-redirects changelog and readme for v2.30.1 2.30.1 add cone size test new baselines generated by CI having new list orders Update config.yml Update config.yml Update config.yml Update config.yml Update config.yml provide dev-deps to bundle stackgl index.js and pin down versions add test-bundle-stackgl regenrate stackgl bundle revise stackgl type from umd to commonjs-module draft log Fix deprecated dependency notation Minor change to replaces a semver v1 notation (with leading `v`) with semver v2. PS: The npm semver package most likely will deprecate semver v1 support in next major. Add shapes.layer value "belowtraces" for drawing shapes in between gridlines and traces Add draftlog Add baseline image for shapes_layer_below_traces.json Make sure new test images run last Update splom_test's innerSubplotNodeCnt and index of xaxislayer-above Rename "belowtraces" to "between" Add "between to newshape.layer as well. Make line length of description shorter. Fix descriptions for shapes.layer and newshape.layer Test more cases in shapes_layer_below_traces mock - added axis y2 to test interaction between axes - added shape label - moved dashdot line to see more of its interaction with the gridlines - removed transparency for easier visual checking Updated baseline image for changed shapes_layer_below_traces mock shapes_layer_below_traces mock: Make y and y2 gridlines visually distinct updated baseline image after changing shapes_layer_below_traces mock Update draftlogs/6927_add.md add vector sizemode option to cone update schema test add new test test sizeref with vector sizemode link to changes in gl-cone3d update stackgl-bundle new mock rename option to raw bump gl-cone3d 1.6.0 and rebuild stackgl index change color countLabel to bandColorCount change parcats_hoveron_color to include count in hoverinfo draftlogs 6944 draftlogs 6944 Update draftlogs/6944_change.md hover on subplots when they anchored to same x or y add jasmine tests test unified hover including points in other plots draft log refactor refactor handle splom splom test do not loop in newly added items rename attribute revise attribute def do not sort items when hovering over multiple subplots rename to hoversubplots revise attributes add single option add test fix case of splom with multiple points at same (x|y) position simplify splom hover mention the PR in draftlogs zindex first pass. scatter and bar traces only Ensure zindex is compared by trace Add zindex basic baseline update plot-schema diff Add zindex to image Add zindex to all cartesian traces Update schema Fix scattergl zindex Add baseline /zindex-scatter-image.png Restore dist Remove scattergl zindex Remove coerce zindex from scattergl Remove zindex from funnelarea Remove zindex from funnelarea Add zindex for ohlc Add mocks for zindex Add baselines Fix zindex_violin_box mock Add draftlog Define zindex in scatter attributes Use Lib.sorterAsc for zindices Handle zindex undefined in sort Update draftlog Update description Update zindex-scatter-image mock Add mocks for zindex in histogram, heatmap, and contour traces Add zindex to histogram traces Fix zindex routing in attributes Update zindex description Add baselines for zindex image, contour, heatmap, and histogram mocks Change zindex editType to 'plot' Add zindex to funnel_axis_with_other_traces mock Add new baseline for funnel_axis_with_other_traces Update plot-schema Fix funnel_axis_with_other_traces baseline Remove zindex_histogram mock and baseline Reduce width and height of zindex mocks Update zindex baselines Add Jasmine tests for zindex Add jasmine test for clearing and adding zindex traces Add select tests for zindex traces Change naming of layers with zindex Remove focus in tests Add zindex tests for bar traces Fix index of layer names for negative zindex Add overlaying bar traces to zindex_basic mock Extend zindex test to waterfall and funnel traces rename zindex to zorder rename new mocks update baselines generated with new order on CircleCI update mapbox-gl version in package-lock npm audit fix take into account zorder when hovering add jasmine test correct click and select test with zorder adjust draftlog update readme and changelog for v2.31.0 2.31.0 npm audit fix fix default trace orders when zorder is present for some add test draftlog fix (x|y) spike position and ensure main subplot hover points are sorted first jasmine test draftlog avoid duplicates in splom hover draftlog comment readme and changelog for v2.31.1 2.31.1 use raw sizemode in gl3d_cone-wind revisit colors Apply autotickangles also on axes with tickson="boundaries" and axes with showdividers=true Add draftlog for PR 6967 Update baseline image tickson_boundaries.png, now honors autotickangles Make test "should rotate labels to avoid overlap" more lenient for float and update expected angle test "should rotate labels to avoid overlap": Fix toBeCloseTo call and deprecation warnings. test "should rotate labels to avoid overlap": Fix next failing test Update test "drag to wide-range -> rotate labels" for autotickangles Update draftlogs/6967_fix.md Fix inconsistent axis title standoff when title is one text line vs. multiple lines. Previously, the standoff was calculated in the same way for all axis sides, but since the renderer draws from top left to bottom right, the code must be different for top/left axes titles and bottom/right axes titles: For top/left axes all lines after the first of a multiline title require extra space before the ticklabels, whereas for bottom/right axes, the drawing baseline needs to be shifted 1 line after the ticklabels to prevent overlap. Add draftlog for PR 6970 For top/left axes side: Account for descender portion (the tail of p, y, g etc.) of the first line of the title as well. Fix axis-title-standoff.json yaxis title text Claimed to have standoff 8 although it has standoff 0. update baselines and new mock (cherry picked from commit 1e69c85) Better draftlog description for PR 6970 Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com> add weight, style, stretch and variant to font bar carpet contour heatmap indicator parcats parcoords pie sankey scatter scattergl sunburst table scatter3d scattermapbox annotations colorbar legend titles hover effects plots cartesian polar ternary gl3d gl-text fix for handling styles new schema add and adjust jasmine tests style waterfall_profit-loss_2018vs2019_textinfo_base style heatmap_xyz-gaps-on-sides style gl2d_text_chart_arrays style text_chart_arrays style text_on_shapes_basic style bar_annotation_max_range_eq_category style texttemplate_scatter style texttemplate fix typo in src/components/fx/hover.js add extras option to integer in lib.coerce declare weight as integer update schema adjust bar fix src/traces/sunburst/fx.js use Lib.coerceFont in indicator style test/image/mocks/indicator_attrs style indicator_bullet style gl2d_parcoords_constraints style parcats_basic_freeform style scattercarpet-text use layout.font in carpet/defaults.js style funnelarea_with_other_traces style treemap_fonts_nocolor style sankey_energy style trace_metatext style parcats fix indicator guage.axis default font Revert "scattermapbox" This reverts commit 2c39a8e. no support in scattermapbox add font style options to gl-axes3d update trace_metatext handle font styles in gl-scatter3d style gl3d_scatter3d-blank-text handle styles in gl-plot2d and text-cache style gl2d_heatmapgl revise font.stretch options correct oblique options drop oblique angle options that are quite confusing remove stretch from src remove stretch from test update schema diff remove stretch in gl-axes3d gl-plot2d and text-cache adjust toimage_test add descriptions fix hover use layout.font styling defaults in hover make arrayOk styling attributes revise variant options image test for font-variants keep working options in test revise new attributes new tests update link to gl-scatter3d handle array font family, weight, style & variant in gl-scatter3d skip font-variant-bar in mock test update package-lock.json test font options in scattergl and scatter3d revise font options limit variant options for scattergl and scatter3d - arrayOk scatter3d family supported now add bold and italic to scattermapbox no integer weight do not include font styling options in svg when set to normal refactor fix mapbox font correct coerce function and remove unused code revise opt name remove comments - these are arrayOk & handled now by gl-scatter3d revise mock fix cluster mapbox font inherit family, weight & style draft log bump gl-text bump stackgl modules npm audit fix changelog and readme for v2.32.0 2.32.0 reduce drawing font args - delete unused method rename new mocks baselines generated on ci with new order adjust parallelism of make-baselines-virtual-webgl to reduce falkiness bump plotly/d3 v3.8.2 - rename unicode var names draft log add text-shadow, text-decoration-line & text-transform in drawing.font declare new text font styling attributes implementation adjust toSVG to skip none text style values set auto shadow for sankey, parcats and parcoords that has text-shadow before update sankey, parcats & parcoords baselines - revise contrast src fix shadow attr def update schema adjust jasmine tests test axes_custom-ticks_log-date test axes_labels test bar_annotation_max_range_eq_category test bar_attrs_group_norm test bar-colorscale-colorbar test bar_gantt-chart test benchmarks test canada_geo_projections test cliponaxis_false-dates-log test container-legend test contour_constraints_equal_boundary_minmax test font-variant-bar test funnel_axis_textangle_outside test funnel_horizontal_group_basic test geo_africa-insets test geo_canadian-cities test geo_country-names-text-chart test geo_text_chart_arrays test geo_text_chart_arrays custom title shadow test heatmap_brick_padding test heatmap-text-color-on-missing-data test indicator_attrs test indicator_scatter test insiderange test pie_legend_line_color_array test polar_bar-overlay test sankey_messy test text_on_shapes_basic test texttemplate test texttemplate_scatter test ticklabelposition-5 test treemap_multi-line_headers introduce overrideDflt option for coerceFont refactor src/components/fx/hover.js fix colorbar.title.font default capitalize none > normal lowercase > lower, uppercase > upper replace case options with object striding > decorline Revert "no integer weight" This reverts commit f4d4f4c. also drop font-weight 400 when exporting to SVG test scatter font weight test bar font weight use numeric font-weight in mocks skip validating font-weight-bar mock draft log numeric text weight in gl3d link to include extra valid font-weight options in css-font and gl-text test numeric font-weight values in scattergl pipeline Revert "link to include extra valid font-weight options in css-font and gl-text" This reverts commit abb3fc8. fall back for unsupported font-weight values scattergl numeric font-weight render using bold/normal fallback correct mock name improve scattergl test test numeric weight in gl2d axis text convert typed array spec in integer, number, color, etc handle typed arrays in scatter3d handle typed arrays in gl-axes3d handle numeric font weight in mapbox supported fonts fix toSVG using weight: 400 improve mapbox text weight and italic handling fix support of Open Sans Extrabold fonts test metropolis fonts on mapbox test italic Metropolis fonts add weight test for open sans fonts - duplicate simple open-sans baseline add weight test for metropolis fonts - duplicate simple metropolis baseline Revert "test italic Metropolis fonts" This reverts commit 190aef1. test numeric weights on axes 3d bump gl-axes3d and gl-scatter3d refactor src/traces/scattergl/convert.js improve font family checks add comment Bring back one new mock tested in 6990 - Revert "Revert "test italic Metropolis fonts"" This reverts commit 59779f3. rename newly added mocks and baselines regenrated baselines due to new order bug on the CI rename keys correct schema capitalize > textcase textcase: word > headline textcase: headline > caps - Capitalizing Every Word Is NOT headline case use new options in trace_metatext mock test new options use Drawing.font to style titles caps > word caps decorline > lineposition clear none text font styles instead of setting to none fix getFullTransformMatrix in shadow DOM Add draft log fix getFullTransformMatrix in shadow DOM fix drag on legend scrollbar Add draft log Improve numerical stability of projection When the position vector has large values that are cancelled out by large values in the model matrix, it is more numerically stable to first multiply the position by the model matrix instead of multiplying the matrices together first. Use forks of the gl-vis libraries that use the problematic pattern. Update 3D baseline images Add draftlog Add one testcase to flaky virtual-webgl tests list Remove overrides in stackgl_modules package.json Update gl-axes3d Update gl-vis dependencies to new upstream versions Update draftlogs/6998_fix.md Improve precision of surface3d worldPosition calculation When the objectOffset is very large compared to the values in the localCoordinate, adding it to the localCoordinate loses precision in the localCoordinate. As the addition of the objectOffset was immediately undone by application of the model matrix, it is better to combine the model matrix and the translation by the objectOffset into one matrix and apply it directly to the localCoordinate. Update surface plot baseline images Add draftlog Update gl-surface3d dependency Add test for small timerange on surface plot Update draftlog Fix syntax of test with small timerange Add baseline for small timerange on surface plot fix isosurface _vMax calculation when isomax is null log for PR 7002 cleanup dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small issue: "Cannot read properties of undefined (reading '0')" if the user moves their mouse to x=0 when dragging the rangeslider. I searched through the rest of the code and this seems to be the only place with the issue.