Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit plotly_click event on touchscreens with "select" dragmode #6724

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

lvlte
Copy link
Contributor

@lvlte lvlte commented Sep 14, 2023

Addresses #6721

Passing sublot id to Fx.click() will force trigger Fx.hover() so that plotly_click event can be emitted with proper data (ie. hoverdata) on touchscreens.

to ensure plotly_click event is emitted on touchscreens.
@archmoj archmoj added bug something broken community community contribution status: reviewable labels Sep 14, 2023
@josephernest
Copy link

josephernest commented Sep 18, 2023

Thanks @lvlte! Is there already a testing .min.js file for this? If so, I'd be interesting for a link, since I'm not really familiar with the whole build process. Thanks!

@archmoj
Copy link
Contributor

archmoj commented Sep 18, 2023

Thanks @lvlte! Is there already a testing .min.js file for this? If so, I'd be interesting for a link, since I'm not really familiar with the whole build process. Thanks!

@josephernest. It's available at https://output.circle-artifacts.com/output/job/5de2be62-ac4b-44d7-8e77-7fcb67432dbe/artifacts/0/dist/plotly.min.js for a couple of days.

@archmoj
Copy link
Contributor

archmoj commented Oct 4, 2023

💃

@archmoj archmoj merged commit c1d4671 into plotly:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken community community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants