-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve rendering of scattergl, splom and parcoords by implementing plotGlPixelRatio for those traces #5500
Conversation
Default respolution is now double the prior value
Here are a two images comparing the interactive appearance of Note that the lines look thinner in this PR because gl lines are fixed at width 1, and the rendering is now performed at twine the resolution (4x more pixels). |
This looks like an awesome improvement! Any idea for when we can expect these changes to be merged? |
I think we decided that this is a bugfix that we could do after 2.0 i.e. in 2.1. also re |
Resolved conflicts and added to v2.3.0 milestone. |
…vice at plotly level
- this fixed splom_large
Thanks @jonmmease for the 💪 PR 🎖️ |
Awaiting merge :) |
You can merge it @archmoj |
This PR updates the
scattergl
andparcoords
traces to honor theconfig.plotGlPixelRatio
parameter. Increasing theplotGlPixelRatio
value now increases the resolution of the WebGL rendered content of these plots, both live and when exported to static images.Closes #5497, and is the first step of addressing plotly/Kaleido#58.
Also closes #5500.
Already working:
scatterploargl
heatmapgl
Fixed:
scattergl
parcoords
splom
TODO:
cc #5395
Examples
Here are some before and after examples. All of these are exported to png images with a
scale
of 3 andplotGlPixelRatio
of 6.Open both images in a new tab to get the full effect.
Scattergl
Before
After
SPLOM
Before
(Note, there was some marker size distortion before)
![before_splom](https://user-images.githubusercontent.com/15064365/107885378-f604f780-6ec7-11eb-8d80-3b81c68a5739.png)
After
Parcoords
Before
After
Note that parcoords lines are thinner because the linewidth must remain at width 1, due to webgl line limitations, instead of increasing in width with
GlPixelRatio
the way thatscattergl
can.Other Change: parcoords text shadow color
(Moved to #5506)
cc @archmoj @nicolaskruchten @alexcjohnson on parcoords style change